fix(event-display): stop animation loop on home

9inpachi · Nov 24, 2020 · c39ecd3 · c39ecd3
1 parent da3ead5
commit c39ecd3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/packages/phoenix-event-display/src/three/index.ts b/packages/phoenix-event-display/src/three/index.ts
@@ -138,6 +138,13 @@ export class ThreeManager {
     this.rendererManager.getMainRenderer().setAnimationLoop(this.animationLoop);
   }
 
+  /**
+   * Stop the animation loop from running.
+   */
+  public stopAnimationLoop() {
+    this.rendererManager.getMainRenderer().setAnimationLoop(null);
+  }
+
   /**
    * Render overlay renderer and effect composer, and update lights.
    */

diff --git a/packages/phoenix-ng/projects/phoenix-app/src/app/home/home.component.ts b/packages/phoenix-ng/projects/phoenix-app/src/app/home/home.component.ts
@@ -12,6 +12,7 @@ export class HomeComponent implements AfterViewInit {
 
   constructor(private eventDisplay: EventDisplayService) {
     this.year = new Date().getFullYear();
+    this.eventDisplay.getThreeManager().stopAnimationLoop();
   }
 
   ngAfterViewInit() {

diff --git a/packages/phoenix-ng/projects/phoenix-ui-components/src/services/event-display.service.ts b/packages/phoenix-ng/projects/phoenix-ui-components/src/services/event-display.service.ts
@@ -7,11 +7,4 @@ import { EventDisplay } from 'phoenix-event-display';
 @Injectable({
   providedIn: 'root'
 })
-export class EventDisplayService extends EventDisplay {
-  /**
-   * Instantiate the event display by calling the parent constructor.
-   */
-  constructor() {
-    super();
-  }
-}
+export class EventDisplayService extends EventDisplay { }