Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultProvider field does not strip whitespace #83

Closed
alexander-bauer opened this issue Sep 22, 2022 · 0 comments
Closed

DefaultProvider field does not strip whitespace #83

alexander-bauer opened this issue Sep 22, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@alexander-bauer
Copy link

Describe the bug
This is a minor behavioral change, but can be pretty hard to troubleshoot, and have major implications.

The DefaultProvider field, and possibly other fields, do not strip whitespace from the outside ends of user input. This can result in behavior including unexpectedly preventing password login

To Reproduce
Steps to reproduce the behavior:

In the SSO admin interface, configure a DefaultProvider with a leading or trailing space. The resulting configuration (retrieved via API) will retain that space.

{
  "keycloak": {
    ...
    "DefaultProvider": " Jellyfin.Server.Implementations.Users.DefaultAuthenticationProvider",
  }
}

Expected behavior
Leading and trailing whitespace should be stripped.

Versions (please complete the following information):

  • OS: Kubernetes on K3OS
  • Browser: Firefox
  • Jellyfin Version: 10.8.4
  • Plugin Version: 3.4.0.0
@alexander-bauer alexander-bauer added the bug Something isn't working label Sep 22, 2022
@9p4 9p4 added the good first issue Good for newcomers label Sep 23, 2022
@9p4 9p4 closed this as completed in 40120dd Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants