-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Distinction Between "p" and "r" Paths Clearer #84
Comments
Whatever solution is created, it should NOT break existing configs. |
How do we want to handle the redirect url changing. Making the routes have multiple paths is easy but the redirect url needs to be configured on the authentication side. When we get to the code below we have no way of telling if they have configured their redirect url to /r/ or /redirect/. Could we assume that if they use /start/ we will use /redirect/ and if they use /p/ we will use /r/?
|
Something like this:
|
I guess there isn't any other option if the auth provider has a whitelist of URLs to redirect to |
Fixed in defab9c |
Is your feature request related to a problem? Please describe.
It seems like there isn't enough of a distinction between the
p
andr
paths for initialization and redirection respectively. Perhaps make the different clearer?Describe the solution you'd like
Replace the
p
paths withstart
andr
withredirect
.Describe alternatives you've considered
Improve the documentation perhaps?
Additional context
#49
#82
#55
#106
The text was updated successfully, but these errors were encountered: