Merge pull request #810 from Aeskull/refactor/merge-if-statements

Combine nested if-statements.
9tigerio · Nov 26, 2024 · 74b2a09 · 74b2a09
2 parents 850cf26 + f6037dc
commit 74b2a09
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pg-dialect/src/main/java/com/homihq/db2rest/jdbc/config/driver/EnvVarSSLSocketFactory.java b/pg-dialect/src/main/java/com/homihq/db2rest/jdbc/config/driver/EnvVarSSLSocketFactory.java
@@ -83,10 +83,10 @@ private void validateCertificate(X509Certificate cert) throws CertificateExcepti
 
         // Check for basic constraints if it's a CA certificate
         int basicConstraints = cert.getBasicConstraints();
-        if (basicConstraints != -1) {  // -1 indicates this is not a CA
-            if (basicConstraints < 0) {
-                throw new CertificateException("Invalid basic constraints for CA certificate");
-            }
+        boolean isNotCA = basicConstraints != -1;
+        boolean isInvalid = basicConstraints < 0;
+        if (isNotCA && isInvalid) {
+            throw new CertificateException("Certificate has invalid subject");
         }
 
         // Log certificate information for debugging