fix on the delete with foreign key constraint, changed response code …

…of delete to 200, added integration test

src/main/java/com/homihq/db2rest/rest/delete/DeleteController.java

@@ -5,7 +5,6 @@
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.http.HttpStatus;
-import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.*;
 
 
@@ -16,7 +15,7 @@ public class DeleteController {
 
     private final DeleteService deleteService;
 
-    @ResponseStatus(HttpStatus.NO_CONTENT)
+    @ResponseStatus(HttpStatus.OK)
     @DeleteMapping("/{tableName}")
     public DeleteResponse delete(@PathVariable String tableName,
                                  @RequestParam(name = "schemaName", required = false) String schemaName,

src/test/java/com/homihq/db2rest/rest/MySQLDeleteAllTest.java

@@ -22,9 +22,9 @@ void delete_all_records_with_allow_safe_delete_false() throws Exception {
         mockMvc.perform(delete("/country")
                         //.header("Content-Profile", "sakila")
                         .accept(APPLICATION_JSON))
-                .andExpect(status().isNoContent())
+                .andExpect(status().isOk())
                 .andExpect(jsonPath("$.rows", Matchers.equalTo(4)))
-                //.andDo(print())
+                .andDo(print())
                 .andDo(document("mysql-delete-a-director"));
     }
 }

src/test/java/com/homihq/db2rest/rest/MySQLDeleteControllerTest.java

@@ -22,9 +22,9 @@ void delete_single_record() throws Exception {
                         .param("filter", "first_name==\"Alex\"")
                        // .header("Content-Profile", "sakila")
                         .accept(APPLICATION_JSON))
-                .andExpect(status().isNoContent())
+                .andExpect(status().isOk())
                 .andExpect(jsonPath("$.rows", Matchers.equalTo(1)))
-                //.andDo(print())
+                .andDo(print())
                 .andDo(document("mysql-delete-a-director"));
     }
 
@@ -37,7 +37,7 @@ void delete_all_records_with_allow_safe_delete_true() throws Exception {
                 .andExpect(status().isBadRequest())
                 .andExpect(jsonPath("$.detail",
                         containsString("Invalid delete operation , safe set to true")))
-                //.andDo(print())
+                .andDo(print())
                 .andDo(document("mysql-delete-a-director"));
     }
 
@@ -65,7 +65,7 @@ void foreign_key_constraint_violation() throws Exception {
                 .andExpect(status().isBadRequest())
                 .andExpect(jsonPath("$.detail",
                         containsString("Cannot delete or update a parent row: a foreign key constraint fails")))
-                //.andDo(print())
+                .andDo(print())
                 .andDo(document("mysql-delete-a-director"));
     }
 }

src/test/java/com/homihq/db2rest/rest/PgDeleteControllerTest.java

@@ -21,9 +21,9 @@ void delete_single_record() throws Exception {
         mockMvc.perform(delete("/director")
                         .param("filter", "first_name==\"Alex\"")
                         .accept(APPLICATION_JSON))
-                .andExpect(status().isNoContent())
+                .andExpect(status().isOk())
                 .andExpect(jsonPath("$.rows", Matchers.equalTo(1)))
-                //.andDo(print())
+                .andDo(print())
                 .andDo(document("pg-delete-a-director"));
     }
 
@@ -35,7 +35,7 @@ void delete_all_records_with_allow_safe_delete_true() throws Exception {
                 .andExpect(status().isBadRequest())
                 .andExpect(jsonPath("$.detail",
                         containsString("Invalid delete operation , safe set to true")))
-                //.andDo(print())
+                .andDo(print())
                 .andDo(document("pg-delete-a-director"));
     }
 
@@ -59,9 +59,10 @@ void foreign_key_constraint_violation() throws Exception {
                         .param("filter", "name==\"English\"")
                         .accept(APPLICATION_JSON))
                 .andExpect(status().isBadRequest())
-                /*.andExpect(jsonPath("$.detail",
-                        containsString("Cannot delete or update a parent row: a foreign key constraint fails")))*/
-                //.andDo(print())
+                .andExpect(jsonPath("$.detail",
+                        containsString("ERROR: update or delete on table \"language\" violates foreign key " +
+                                "constraint \"film_language_id_fkey\" on table \"film")))
+                .andDo(print())
                 .andDo(document("pg-delete-a-director"));
     }
 }