Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous wording for TSID design #282

Closed
thadguidry opened this issue Feb 15, 2024 · 1 comment
Closed

Ambiguous wording for TSID design #282

thadguidry opened this issue Feb 15, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@thadguidry
Copy link
Collaborator

In /design/insert.md

  1. Construct INSERT columns with the key set of the incoming data object.
  2. If includeColumns is specified then use those instead of 1.
  3. If a column with default value is not included in 1 or 2 above then it will be set to the default value by the database.
  4. If tsIdEnabed = true, then find the primary key columns.
    • detect the data type - if integer type, set a numeric TSID.
    • if the data type is string - set string type TSID.
    • add these columns in the data.

That last bullet is confusing to me. "add these columns in the data"
WHICH columns to add? The primary key columns? or the key columns from the incoming data object from 1?
Maybe re-word that last bullet for clarity.

@thadguidry thadguidry added the documentation Improvements or additions to documentation label Feb 15, 2024
@kdhrubo
Copy link
Collaborator

kdhrubo commented Feb 15, 2024

tsid is only applicable for the primary key columns. Step4 is only works with PK columns as stated in the first line.

kdhrubo pushed a commit that referenced this issue Feb 15, 2024
@kdhrubo kdhrubo added this to the Feb2024 milestone Feb 15, 2024
kdhrubo added a commit that referenced this issue Feb 15, 2024
@kdhrubo kdhrubo closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants