Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#130 - doc updates for docker install paragraph. #131

Merged
merged 1 commit into from
Jan 12, 2024
Merged

#130 - doc updates for docker install paragraph. #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
src/test/resources/mysql/mysql-sakila.sql linguist-generated=true
src/test/resources/mysql/mysql-sakila-insert-data.sql linguist-generated=true

src/test/resources/pg/postgres-sakila.sql linguist-generated=true
2 changes: 1 addition & 1 deletion .github/workflows/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: CI Build
on:
push:
branches:
- '**'
- 'feature/**'
jobs:
build:
name: Maven Build
Expand Down
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its fine that your changing and improving lines L96-98
But L71 still says

In order to download the latest edition(v-0.0.8) of DB2Rest click here.

and that [here] link points to Docker get-started, AND NOT ANY JAR FILE !?!?

Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,9 @@ Once this command is executed, within a few seconds, DB2Rest is ready to service

### 1. Install Docker

Docker can be downloaded from the link [here](https://www.docker.com/get-started/) based on your operating system (OS). After download is completed, follow the steps outlined [here]https://docs.docker.com/desktop/
as per your OS, to install Docker desktop.
In order to download Docker desktop browse to this [link](https://www.docker.com/get-started/). This page then shows options
to download Docker for Mac, Windows and Linux. Please click on the link as per your operating system (OS) to start the download.
After download is completed, follow the steps outlined [here]https://docs.docker.com/desktop/ pertinent to your OS, to install and test Docker desktop.

### 2. Run DB2Rest

Expand Down