Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added tsid column check and add autogenerated tsid #143

Merged
merged 2 commits into from
Jan 14, 2024
Merged

added tsid column check and add autogenerated tsid #143

merged 2 commits into from
Jan 14, 2024

Conversation

bharath8121
Copy link
Contributor

@bharath8121 bharath8121 commented Jan 14, 2024 •
edited by thadguidry
Loading

fixes #85

@bharath8121 bharath8121 requested a review from kdhrubo January 14, 2024 01:42
kdhrubo
kdhrubo approved these changes Jan 14, 2024
View reviewed changes
Copy link
Collaborator

@kdhrubo kdhrubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Simplified, existing tests passed.
Need to add tests for this in a separate issue

@kdhrubo kdhrubo merged commit 282f137 into master Jan 14, 2024
@kdhrubo kdhrubo deleted the feature/issue-85 branch January 15, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdhrubo kdhrubo kdhrubo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for TSID for primary key column.
3 participants
@bharath8121 @kdhrubo @grabdoc