Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added tsid for bulk creation and tests #152

Merged
merged 5 commits into from
Jan 18, 2024
Merged

added tsid for bulk creation and tests #152

merged 5 commits into from
Jan 18, 2024

Conversation

bharath8121
Copy link
Contributor

@bharath8121 bharath8121 commented Jan 17, 2024 •
edited by thadguidry
Loading

Fixes #146

Added:

  1. tsid support for bulk creation
  2. tests to test tsid for create
  3. tests to test tsid for bulk create

Tests include the following scenarios:

  1. tsidType matches with defined type
  2. tsidType doesn't match with defined type
  3. tsidType not provided (default is used)

@kdhrubo kdhrubo self-requested a review January 18, 2024 03:58
@kdhrubo kdhrubo added the enhancement New feature or request label Jan 18, 2024
@kdhrubo kdhrubo added this to the Jan2024 milestone Jan 18, 2024
@kdhrubo kdhrubo merged commit db4fcf7 into master Jan 18, 2024
1 check passed
@kdhrubo kdhrubo deleted the feature/issue-145 branch January 18, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdhrubo kdhrubo Awaiting requested review from kdhrubo

Assignees

@bharath8121 bharath8121

Labels
enhancement New feature or request
Projects
None yet
Milestone
Jan2024
Development

Successfully merging this pull request may close these issues.

Add integration test for TSID in bulk insert
3 participants
@bharath8121 @kdhrubo @grabdoc