Issue #263 : Separate test data from the tests and refactor tests #267
Conversation
| import lombok.experimental.UtilityClass; | ||
|
|
||
| @UtilityClass | ||
| public class ITestUtil { |
There was a problem hiding this comment.
This is static data (almost module like). And looks like only data for Films, so I'd likely rename this to something like /RequestFilmData.java
There was a problem hiding this comment.
and instead of a path like src/test/java/com/homihq/db2rest/utils/ITestUtil.java perhaps be named and moved to a concise path of src/test/data/RequestFilmData.java
There was a problem hiding this comment.
@thadguidry please log an issue. This can be a good first issue :)
I am not sure at this time but JUNIT 5 probably allows loading test data from external sources better than earlier versions.
In that case, test data like this can be sourced from JSON files instead.
There was a problem hiding this comment.
And if we are rubbing against the old Maven folder conventions, then we likely don't have our POM setup correctly so that we can have good concise paths.
There was a problem hiding this comment.
@thadguidry @kdhrubo The integrations tests were a mess. Extracting test data into an util class was the first step, next we'll take further steps to organise the test data. I thought about having separate test json files and load those files as resources during tests, which'll be the next step
No description provided.