Search/replace Debug.Assert(false, => Debug.Fail( (dotnet#4782)

A-And · Oct 31, 2017 · 4933d30 · 4933d30
1 parent 28947a8
commit 4933d30
Show file tree

Hide file tree

Showing 65 changed files with 108 additions and 108 deletions.
diff --git a/src/Common/src/Internal/Runtime/EETypeBuilderHelpers.cs b/src/Common/src/Internal/Runtime/EETypeBuilderHelpers.cs
@@ -52,7 +52,7 @@ private static CorElementType ComputeRhCorElementType(TypeDesc type)
                     break;
             }
 
-            Debug.Assert(false, "Primitive type value expected.");
+            Debug.Fail("Primitive type value expected.");
             return 0;
         }
 

diff --git a/src/Common/src/System/Collections/Concurrent/ConcurrentUnifier.cs b/src/Common/src/System/Collections/Concurrent/ConcurrentUnifier.cs
@@ -282,7 +282,7 @@ public void VerifyUnifierConsistency()
                         if (walk2 != -1)
                             walk2 = _entries[walk2]._next;
                         if (walk1 == walk2 && walk2 != -1)
-                            Debug.Assert(false, "Bucket " + bucket + " has a cycle in its linked list.");
+                            Debug.Fail("Bucket " + bucket + " has a cycle in its linked list.");
                     }
                 }
                 // The assertion is "<=" rather than "==" because we allow an entry to "leak" until the next resize if 

diff --git a/src/Common/src/System/Collections/Concurrent/ConcurrentUnifierW.cs b/src/Common/src/System/Collections/Concurrent/ConcurrentUnifierW.cs
@@ -220,7 +220,7 @@ public void Add(K key, int hashCode, V value)
                         {
                             V heyYoureSupposedToBeDead;
                             if (_entries[idx]._weakValue.TryGetTarget(out heyYoureSupposedToBeDead))
-                                Debug.Assert(false, "Add: You were supposed to verify inside the lock that this entry's weak reference had already expired!");
+                                Debug.Fail("Add: You were supposed to verify inside the lock that this entry's weak reference had already expired!");
                         }
 #endif //DEBUG
                         _entries[idx]._weakValue = new WeakReference<V>(value, trackResurrection: false);
@@ -367,7 +367,7 @@ public void VerifyUnifierConsistency()
                         if (walk2 != -1)
                             walk2 = _entries[walk2]._next;
                         if (walk1 == walk2 && walk2 != -1)
-                            Debug.Assert(false, "Bucket " + bucket + " has a cycle in its linked list.");
+                            Debug.Fail("Bucket " + bucket + " has a cycle in its linked list.");
                     }
                 }
                 // The assertion is "<=" rather than "==" because we allow an entry to "leak" until the next resize if 

diff --git a/src/Common/src/System/Collections/Concurrent/ConcurrentUnifierWKeyed.cs b/src/Common/src/System/Collections/Concurrent/ConcurrentUnifierWKeyed.cs
@@ -362,7 +362,7 @@ public void VerifyUnifierConsistency()
                         if (walk2 != -1)
                             walk2 = _entries[walk2]._next;
                         if (walk1 == walk2 && walk2 != -1)
-                            Debug.Assert(false, "Bucket " + bucket + " has a cycle in its linked list.");
+                            Debug.Fail("Bucket " + bucket + " has a cycle in its linked list.");
                     }
                 }
                 // The assertion is "<=" rather than "==" because we allow an entry to "leak" until the next resize if 

diff --git a/src/Common/src/System/SR.cs b/src/Common/src/System/SR.cs
@@ -63,7 +63,7 @@ private static string InternalGetResourceString(string key)
         {
             if (key == null || key.Length == 0)
             {
-                Debug.Assert(false, "SR::GetResourceString with null or empty key.  Bug in caller, or weird recursive loading problem?");
+                Debug.Fail("SR::GetResourceString with null or empty key.  Bug in caller, or weird recursive loading problem?");
                 return key;
             }
 

diff --git a/src/Common/src/TypeSystem/Canon/GenericParameterDesc.Canon.cs b/src/Common/src/TypeSystem/Canon/GenericParameterDesc.Canon.cs
@@ -11,13 +11,13 @@ public partial class GenericParameterDesc
     {
         public sealed override bool IsCanonicalSubtype(CanonicalFormKind policy)
         {
-            Debug.Assert(false, "IsCanonicalSubtype of an indefinite type");
+            Debug.Fail("IsCanonicalSubtype of an indefinite type");
             return false;
         }
 
         protected sealed override TypeDesc ConvertToCanonFormImpl(CanonicalFormKind kind)
         {
-            Debug.Assert(false, "ConvertToCanonFormImpl for an indefinite type");
+            Debug.Fail("ConvertToCanonFormImpl for an indefinite type");
             return this;
         }
     }

diff --git a/src/Common/src/TypeSystem/Canon/SignatureVariable.Canon.cs b/src/Common/src/TypeSystem/Canon/SignatureVariable.Canon.cs
@@ -11,13 +11,13 @@ partial class SignatureTypeVariable
     {
         public override bool IsCanonicalSubtype(CanonicalFormKind policy)
         {
-            Debug.Assert(false, "IsCanonicalSubtype of an indefinite type");
+            Debug.Fail("IsCanonicalSubtype of an indefinite type");
             return false;
         }
 
         protected override TypeDesc ConvertToCanonFormImpl(CanonicalFormKind kind)
         {
-            Debug.Assert(false, "ConvertToCanonFormImpl for an indefinite type");
+            Debug.Fail("ConvertToCanonFormImpl for an indefinite type");
             return this;
         }
     }
@@ -27,13 +27,13 @@ partial class SignatureMethodVariable
     {
         public override bool IsCanonicalSubtype(CanonicalFormKind policy)
         {
-            Debug.Assert(false, "IsCanonicalSubtype of an indefinite type");
+            Debug.Fail("IsCanonicalSubtype of an indefinite type");
             return false;
         }
 
         protected override TypeDesc ConvertToCanonFormImpl(CanonicalFormKind kind)
         {
-            Debug.Assert(false, "ConvertToCanonFormImpl for an indefinite type");
+            Debug.Fail("ConvertToCanonFormImpl for an indefinite type");
             return this;
         }
     }

diff --git a/src/Common/src/TypeSystem/Common/MetadataFieldLayoutAlgorithm.cs b/src/Common/src/TypeSystem/Common/MetadataFieldLayoutAlgorithm.cs
@@ -614,7 +614,7 @@ public override DefType ComputeHomogeneousFloatAggregateElementType(DefType type
                         break;
 
                     default:
-                        Debug.Assert(false, "Why is IsHfa true on this type?");
+                        Debug.Fail("Why is IsHfa true on this type?");
                         return null;
                 }
             }

diff --git a/src/Common/src/TypeSystem/Common/ThrowHelper.Common.cs b/src/Common/src/TypeSystem/Common/ThrowHelper.Common.cs
@@ -66,7 +66,7 @@ public static string Module(ModuleDesc module)
                 }
                 else
                 {
-                    Debug.Assert(false, "Multi-module assemblies");
+                    Debug.Fail("Multi-module assemblies");
                     return module.ToString();
                 }
             }

diff --git a/src/Common/src/TypeSystem/Common/TypeSystemHelpers.cs b/src/Common/src/TypeSystem/Common/TypeSystemHelpers.cs
@@ -153,7 +153,7 @@ public static MethodDesc FindMethodOnTypeWithMatchingTypicalMethod(this TypeDesc
                 targetOrBase = targetOrBase.BaseType;
             } while (targetOrBase != null);
 
-            Debug.Assert(false, "method has no related type in the type hierarchy of type");
+            Debug.Fail("method has no related type in the type hierarchy of type");
             return null;
         }
 

diff --git a/src/Common/src/TypeSystem/Ecma/EcmaType.MethodImpls.cs b/src/Common/src/TypeSystem/Ecma/EcmaType.MethodImpls.cs
@@ -58,7 +58,7 @@ public override MethodImplRecord[] FindMethodsImplWithMatchingDeclName(string de
                         break;
 
                     default:
-                        Debug.Assert(false, "unexpected methodDeclHandleKind");
+                        Debug.Fail("unexpected methodDeclHandleKind");
                         break;
                 }
 
@@ -113,7 +113,7 @@ protected override MethodImplRecord[] ComputeVirtualMethodImplsForType()
                         break;
 
                     default:
-                        Debug.Assert(false, "unexpected methodDeclHandleKind");
+                        Debug.Fail("unexpected methodDeclHandleKind");
                         break;
                 }
 

diff --git a/src/Common/src/TypeSystem/IL/Stubs/DelegateMarshallingMethodThunk.cs b/src/Common/src/TypeSystem/IL/Stubs/DelegateMarshallingMethodThunk.cs
@@ -209,7 +209,7 @@ private string NamePrefix
                     case DelegateMarshallingMethodThunkKind.ForwardNativeFunctionWrapper:
                         return "ForwardNativeFunctionWrapper";
                     default:
-                        System.Diagnostics.Debug.Assert(false, "Unexpected DelegateMarshallingMethodThunkKind.");
+                        System.Diagnostics.Debug.Fail("Unexpected DelegateMarshallingMethodThunkKind.");
                         return String.Empty;
                 }
             }

diff --git a/src/Common/src/TypeSystem/IL/Stubs/ILEmitter.cs b/src/Common/src/TypeSystem/IL/Stubs/ILEmitter.cs
@@ -256,7 +256,7 @@ public void EmitLdInd(TypeDesc type)
                     Emit(ILOpcode.ldobj, _emitter.NewToken(type));
                     break;
                 default:
-                    Debug.Assert(false, "Unexpected TypeDesc category");
+                    Debug.Fail("Unexpected TypeDesc category");
                     break;
             }
         }
@@ -305,7 +305,7 @@ public void EmitStInd(TypeDesc type)
                     Emit(ILOpcode.stobj, _emitter.NewToken(type));
                     break;
                 default:
-                    Debug.Assert(false, "Unexpected TypeDesc category");
+                    Debug.Fail("Unexpected TypeDesc category");
                     break;
             }
         }
@@ -355,7 +355,7 @@ public void EmitStElem(TypeDesc type)
                     Emit(ILOpcode.stelem, _emitter.NewToken(type));
                     break;
                 default:
-                    Debug.Assert(false, "Unexpected TypeDesc category");
+                    Debug.Fail("Unexpected TypeDesc category");
                     break;
             }
         }
@@ -405,7 +405,7 @@ public void EmitLdElem(TypeDesc type)
                     Emit(ILOpcode.ldelem, _emitter.NewToken(type));
                     break;
                 default:
-                    Debug.Assert(false, "Unexpected TypeDesc category");
+                    Debug.Fail("Unexpected TypeDesc category");
                     break;
             }
         }

diff --git a/src/Common/src/TypeSystem/IL/Stubs/PInvokeILEmitter.cs b/src/Common/src/TypeSystem/IL/Stubs/PInvokeILEmitter.cs
@@ -208,7 +208,7 @@ private void EmitDelegateCall(DelegateMarshallingMethodThunk delegateMethod, PIn
             }
             else
             {
-                Debug.Assert(false, "Unexpected DelegateMarshallingMethodThunkKind");
+                Debug.Fail("Unexpected DelegateMarshallingMethodThunkKind");
             }
         }
 

diff --git a/src/Common/src/TypeSystem/IL/Stubs/StructMarshallingThunk.cs b/src/Common/src/TypeSystem/IL/Stubs/StructMarshallingThunk.cs
@@ -105,7 +105,7 @@ private string NamePrefix
                     case StructMarshallingThunkType.Cleanup:
                         return "Cleanup";
                     default:
-                        System.Diagnostics.Debug.Assert(false, "Unexpected Struct marshalling thunk type");
+                        System.Diagnostics.Debug.Fail("Unexpected Struct marshalling thunk type");
                         return string.Empty;
                 }
             }

diff --git a/src/Common/src/TypeSystem/Interop/IL/Marshaller.cs b/src/Common/src/TypeSystem/Interop/IL/Marshaller.cs
@@ -225,7 +225,7 @@ public void StoreValue(ILCodeStream stream)
                 switch (_homeType)
                 {
                     case HomeType.Arg:
-                        Debug.Assert(false, "Unexpectting setting value on non-byref arg");
+                        Debug.Fail("Unexpectting setting value on non-byref arg");
                         break;
                     case HomeType.Local:
                         stream.EmitStLoc(_var);

diff --git a/src/Common/src/TypeSystem/Interop/MethodDesc.Interop.cs b/src/Common/src/TypeSystem/Interop/MethodDesc.Interop.cs
@@ -184,7 +184,7 @@ public MethodSignatureFlags UnmanagedCallingConvention
                         _attributes |= PInvokeAttributes.CallingConventionThisCall;
                         break;
                     default:
-                        System.Diagnostics.Debug.Assert(false, "Unexpected Unmanaged Calling Convention.");
+                        System.Diagnostics.Debug.Fail("Unexpected Unmanaged Calling Convention.");
                         break;
                 }
             }

diff --git a/src/Common/src/TypeSystem/NativeFormat/NativeFormatType.MethodImpls.cs b/src/Common/src/TypeSystem/NativeFormat/NativeFormatType.MethodImpls.cs
@@ -98,7 +98,7 @@ protected override MethodImplRecord[] ComputeVirtualMethodImplsForType()
                         break;
 
                     default:
-                        Debug.Assert(false, "unexpected methodDeclHandleType");
+                        Debug.Fail("unexpected methodDeclHandleType");
                         break;
                 }
 

diff --git a/src/Common/src/TypeSystem/RuntimeDetermined/GenericParameterDesc.RuntimeDetermined.cs b/src/Common/src/TypeSystem/RuntimeDetermined/GenericParameterDesc.RuntimeDetermined.cs
@@ -12,7 +12,7 @@ public sealed override bool IsRuntimeDeterminedSubtype
         {
             get
             {
-                Debug.Assert(false, "IsRuntimeDeterminedSubtype of an indefinite type");
+                Debug.Fail("IsRuntimeDeterminedSubtype of an indefinite type");
                 return false;
             }
         }

diff --git a/src/Common/src/TypeSystem/RuntimeDetermined/SignatureVariable.RuntimeDetermined.cs b/src/Common/src/TypeSystem/RuntimeDetermined/SignatureVariable.RuntimeDetermined.cs
@@ -12,7 +12,7 @@ public sealed override bool IsRuntimeDeterminedSubtype
         {
             get
             {
-                Debug.Assert(false, "IsRuntimeDeterminedSubtype of an indefinite type");
+                Debug.Fail("IsRuntimeDeterminedSubtype of an indefinite type");
                 return false;
             }
         }

diff --git a/src/ILCompiler.Compiler/src/Compiler/CompilationModuleGroup.cs b/src/ILCompiler.Compiler/src/Compiler/CompilationModuleGroup.cs
@@ -102,7 +102,7 @@ public AssemblyName GetName()
 
             public override MetadataType GetType(string nameSpace, string name, bool throwIfNotFound = true)
             {
-                Debug.Assert(false, "Resolving a TypeRef in the compiler generated assembly?");
+                Debug.Fail("Resolving a TypeRef in the compiler generated assembly?");
 
                 if (throwIfNotFound)
                     ThrowHelper.ThrowTypeLoadException(nameSpace, name, this);

diff --git a/src/ILCompiler.Compiler/src/Compiler/CompilerTypeSystemContext.cs b/src/ILCompiler.Compiler/src/Compiler/CompilerTypeSystemContext.cs
@@ -62,7 +62,7 @@ protected override bool CompareValueToValue(ModuleData value1, ModuleData value2
             }
             protected override ModuleData CreateValueFromKey(EcmaModule key)
             {
-                Debug.Assert(false, "CreateValueFromKey not supported");
+                Debug.Fail("CreateValueFromKey not supported");
                 return null;
             }
         }
@@ -90,7 +90,7 @@ protected override bool CompareValueToValue(ModuleData value1, ModuleData value2
             }
             protected override ModuleData CreateValueFromKey(string key)
             {
-                Debug.Assert(false, "CreateValueFromKey not supported");
+                Debug.Fail("CreateValueFromKey not supported");
                 return null;
             }
         }

diff --git a/src/ILCompiler.Compiler/src/Compiler/DelegateCreationInfo.cs b/src/ILCompiler.Compiler/src/Compiler/DelegateCreationInfo.cs
@@ -129,7 +129,7 @@ public ISymbolNode GetTargetNode(NodeFactory factory)
                     return factory.RuntimeMethodHandle(TargetMethod);
 
                 case TargetKind.VTableLookup:
-                    Debug.Assert(false, "Need to do runtime lookup");
+                    Debug.Fail("Need to do runtime lookup");
                     return null;
 
                 default:

diff --git a/src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/GenericLookupResult.cs b/src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/GenericLookupResult.cs
@@ -372,7 +372,7 @@ public FieldOffsetGenericLookupResult(FieldDesc field)
 
         public override ISymbolNode GetTarget(NodeFactory factory, GenericLookupResultContext dictionary)
         {
-            Debug.Assert(false, "GetTarget for a FieldOffsetGenericLookupResult doesn't make sense. It isn't a pointer being emitted");
+            Debug.Fail("GetTarget for a FieldOffsetGenericLookupResult doesn't make sense. It isn't a pointer being emitted");
             return null;
         }
 
@@ -435,13 +435,13 @@ public VTableOffsetGenericLookupResult(MethodDesc method)
 
         public override ISymbolNode GetTarget(NodeFactory factory, GenericLookupResultContext dictionary)
         {
-            Debug.Assert(false, "GetTarget for a VTableOffsetGenericLookupResult doesn't make sense. It isn't a pointer being emitted");
+            Debug.Fail("GetTarget for a VTableOffsetGenericLookupResult doesn't make sense. It isn't a pointer being emitted");
             return null;
         }
 
         public override void EmitDictionaryEntry(ref ObjectDataBuilder builder, NodeFactory factory, GenericLookupResultContext dictionary, GenericDictionaryNode dictionaryNode)
         {
-            Debug.Assert(false, "VTableOffset contents should only be generated into generic dictionaries at runtime");
+            Debug.Fail("VTableOffset contents should only be generated into generic dictionaries at runtime");
             builder.EmitNaturalInt(0);
         }
 
@@ -1436,13 +1436,13 @@ public CallingConventionConverterLookupResult(CallingConventionConverterKey call
 
         public override ISymbolNode GetTarget(NodeFactory factory, GenericLookupResultContext dictionary)
         {
-            Debug.Assert(false, "GetTarget for a CallingConventionConverterLookupResult doesn't make sense. It isn't a pointer being emitted");
+            Debug.Fail("GetTarget for a CallingConventionConverterLookupResult doesn't make sense. It isn't a pointer being emitted");
             return null;
         }
 
         public override void EmitDictionaryEntry(ref ObjectDataBuilder builder, NodeFactory factory, GenericLookupResultContext dictionary, GenericDictionaryNode dictionaryNode)
         {
-            Debug.Assert(false, "CallingConventionConverterLookupResult contents should only be generated into generic dictionaries at runtime");
+            Debug.Fail("CallingConventionConverterLookupResult contents should only be generated into generic dictionaries at runtime");
             builder.EmitNaturalInt(0);
         }
 
@@ -1499,7 +1499,7 @@ public TypeSizeLookupResult(TypeDesc type)
         }
         public override ISymbolNode GetTarget(NodeFactory factory, GenericLookupResultContext dictionary)
         {
-            Debug.Assert(false, "GetTarget for a TypeSizeLookupResult doesn't make sense. It isn't a pointer being emitted");
+            Debug.Fail("GetTarget for a TypeSizeLookupResult doesn't make sense. It isn't a pointer being emitted");
             return null;
         }
 

diff --git a/src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/NativeLayoutVertexNode.cs b/src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/NativeLayoutVertexNode.cs
@@ -440,7 +440,7 @@ public override Vertex WriteVertex(NodeFactory factory)
                         }
                 }
 
-                Debug.Assert(false, "UNREACHABLE");
+                Debug.Fail("UNREACHABLE");
                 return null;
             }
         }
@@ -467,7 +467,7 @@ public override Vertex WriteVertex(NodeFactory factory)
                         return GetNativeWriter(factory).GetVariableTypeSignature((uint)((SignatureMethodVariable)_type).Index, true);
                 }
 
-                Debug.Assert(false, "UNREACHABLE");
+                Debug.Fail("UNREACHABLE");
                 return null;
             }
         }

diff --git a/src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/ObjectWriter.cs b/src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/ObjectWriter.cs
@@ -928,7 +928,7 @@ public static void EmitObject(string objectFilePath, IEnumerable<DependencyNode>
                         catch (ArgumentException)
                         {
                             ISymbolNode alreadyWrittenSymbol = _previouslyWrittenNodeNames[definedSymbol.GetMangledName(factory.NameMangler)];
-                            Debug.Assert(false, "Duplicate node name emitted to file",
+                            Debug.Fail("Duplicate node name emitted to file",
                             $"Symbol {definedSymbol.GetMangledName(factory.NameMangler)} has already been written to the output object file {objectFilePath} with symbol {alreadyWrittenSymbol}");
                         }
                     }

diff --git a/src/ILCompiler.CppCodeGen/src/CppCodeGen/EvaluationStack.cs b/src/ILCompiler.CppCodeGen/src/CppCodeGen/EvaluationStack.cs
@@ -503,7 +503,7 @@ protected InvalidEntry() : base(StackValueKind.Unknown, null)
         public override void Append(CppGenerationBuffer _builder)
         {
             _builder.Append("// FIXME: An invalid value was pushed onto the evaluation stack.");
-            Debug.Assert(false, "Invalid stack values shouldn't be appended.");
+            Debug.Fail("Invalid stack values shouldn't be appended.");
         }
 
         public override StackEntry Duplicate()

diff --git a/src/ILCompiler.CppCodeGen/src/CppCodeGen/ILToCppImporter.cs b/src/ILCompiler.CppCodeGen/src/CppCodeGen/ILToCppImporter.cs
@@ -1723,7 +1723,7 @@ private void ImportBinaryOperation(ILOpcode opcode)
                 case ILOpcode.mul_ovf: op = "*"; break;
                 case ILOpcode.mul_ovf_un: op = "*"; unsigned = true; break;
 
-                default: Debug.Assert(false, "Unexpected opcode"); break;
+                default: Debug.Fail("Unexpected opcode"); break;
             }
 
             if (kind == StackValueKind.ByRef)

diff --git a/src/ILCompiler.WebAssembly/src/CodeGen/WebAssemblyObjectWriter.cs b/src/ILCompiler.WebAssembly/src/CodeGen/WebAssemblyObjectWriter.cs
@@ -688,7 +688,7 @@ public static void EmitObject(string objectFilePath, IEnumerable<DependencyNode>
                         catch (ArgumentException)
                         {
                             ISymbolNode alreadyWrittenSymbol = _previouslyWrittenNodeNames[definedSymbol.GetMangledName(factory.NameMangler)];
-                            Debug.Assert(false, "Duplicate node name emitted to file",
+                            Debug.Fail("Duplicate node name emitted to file",
                             $"Symbol {definedSymbol.GetMangledName(factory.NameMangler)} has already been written to the output object file {objectFilePath} with symbol {alreadyWrittenSymbol}");
                         }
                     }