Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] update element role mappings #550

Merged

Conversation

jlp-craigmorten
Copy link
Contributor

@jlp-craigmorten jlp-craigmorten commented Apr 1, 2024

Resolves #553

The mappings for hgroup, s, and search elements are missing or are incorrect/outdated.

This updates as so:

  • hgroup element is now associated with the group role and no longer associated with the generic role.
  • s element is now associated with the deletion role.
  • search element is now associated with the search role.

Relevant specs:

See also Web Platform Tests for HTML-AAM roles.

Copy link

codesandbox-ci bot commented Apr 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@coveralls
Copy link

coveralls commented Apr 1, 2024

Pull Request Test Coverage Report for Build 10141393379

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.491%

Totals Coverage Status
Change from base Build 9879751240: 0.0%
Covered Lines: 285
Relevant Lines: 289

💛 - Coveralls

@ljharb ljharb force-pushed the feat-element-role-mapping-updates branch from 676409d to 047c969 Compare July 8, 2024 04:43
@ljharb ljharb changed the title fix: update element role mappings feat: update element role mappings Jul 8, 2024
@ljharb
Copy link
Collaborator

ljharb commented Jul 8, 2024

@jlp-craigmorten is this PR semver patch or minor, do you think?

@cmorten
Copy link
Contributor

cmorten commented Jul 8, 2024

@jlp-craigmorten is this PR semver patch or minor, do you think?

Suspect at least a minor here: some of these mappings were likely revised or added in specs since their last manifestation in this project so a patch doesn’t quite feel appropriate as the introducing change wasn’t incorrect at the time.

Pertinent parts of HTML-AAM changelog:

  • 12-Dec-2022: Revise mapping for s element to be role=deletion. See GitHub PR 442.
  • 08-Mar-2023: Update hgroup element to be mapped to role=group. See GitHub PR 398.
  • 24-Mar-2023: Add search element and its mappings. See GitHub PR 355.

REF: https://www.w3.org/TR/html-aam-1.0/#substantive-changes-since-moving-to-the-accessible-rich-internet-applications-working-group-03-nov-2019

@jlp-craigmorten jlp-craigmorten force-pushed the feat-element-role-mapping-updates branch from 047c969 to a69bbc4 Compare July 29, 2024 09:07
@ljharb ljharb force-pushed the feat-element-role-mapping-updates branch from 75803f7 to c151daf Compare September 23, 2024 01:45
@ljharb ljharb changed the title feat: update element role mappings [New] update element role mappings Sep 23, 2024
@ljharb ljharb merged commit c151daf into A11yance:main Sep 23, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Incorrect element role mappings
4 participants