Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update role none to match role presentation, update role doc-pullquote to match specification #551

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

huynhducduy
Copy link

Description

  • Role none introduced as a synonym to presentation role, thus must have the same configuration as presentation role.
  • Based on DPub-ARIA 1.1, role doc-pullquote incorrectedly have superClass of none, which should be section

Sumary of changes

  • Update configuration of role none to match role presentation
  • Add tests for role none to be the same as role presentation's tests
  • Update superClass of doc-pullquote to section instead of none

Copy link

codesandbox-ci bot commented Apr 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@cmorten cmorten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that my approval is worth much, but LGTM

I wonder with future synonyms dropping such as image for img whether synonyms should be described as part of the interface (perhaps as part of related concepts, or a new field), but maybe one for a separate change

@ljharb
Copy link
Collaborator

ljharb commented Jul 8, 2024

tests appear to be failing

@jlp-craigmorten
Copy link
Contributor

Worth noting the "update role doc-pullquote to match specification" aspect of this change is as a result of differences between versions 1.0 and 1.1 of the DPUB-ARIA specification, see:

In addition to the superclass role, there are also differences in the listed "inherited states and properties".

Assuming aria-query was based off of the 1.0 spec (a reasonable assumption given it's reflection), this should be considered a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants