Remove dequal from the project #554
Conversation
Previously the code was comparing ElementARIARoleRelationTuple to a ARIARoleRelationConcept which would always be false, flatten the code based on this finding. LCOV similarly also shows that this codepath was never utilized.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Are we confident the types are correct tho? |
Pull Request Test Coverage Report for Build 9797843892Details
💛 - Coveralls |
Great question - my ladder of logic was
From this I have a reasonable level of confidence as to the correctness of the flow typing |
|
That makes sense - is there a chance that this is masking a bug, and it should be executing that code? If so, deleting it seems worse than trying to figure it out, or leaving it there. |
I have root caused the defect however I need guidance from the project owner on what to do with the failures as a result of the long-simmering defect introducing drift in the fixtures file that is part of the tests For now my recommendation would be to land this change, and we can use the other PR to reintroduce the correct code (as right now the logic in place is not only misleading but totally unused) |
Unroll the equality check inside of the file for the specifc type comparision.
Pull Request Test Coverage Report for Build 9799139177Details
💛 - Coveralls |
As discovered in A11yance#554 Address the defect introduced f7f6120#r143856081 This change depends on A11yance#558 which when applied (as in this PR makes the teset cases pass)
As discovered in A11yance#554 Address the defect introduced f7f6120#r143856081 This change depends on A11yance#558 which when applied (as in this PR makes the teset cases pass)
As discovered in A11yance#554 Address the defect introduced f7f6120#r143856081 This change depends on A11yance#558 which when applied (as in this PR makes the teset cases pass)
As discovered in A11yance#554 Address the defect introduced f7f6120#r143856081 This change depends on A11yance#558 which when applied (as in this PR makes the teset cases pass)
These two changes combined remove the need to pull in the dependency to the project.
This PR is inspired by the work done in A11yance/axobject-query#357 and A11yance/axobject-query#354
As an interesting finding when walking through the code to remove this dependency I discovered(in 431ad28) that the prior code-path utilizing dequal was impossible (always false situation)
Specifically we were doing a comparison between
and
Which given the definition of a flow typed union means that these two types have NO overlap.