Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs investigation -- Requesting server name via plugin message should happen on a delay #237

Closed
2 tasks done
A248 opened this issue Oct 2, 2023 · 0 comments
Closed
2 tasks done
Labels
bug Interferes with efficient operation
Milestone

Comments

@A248
Copy link
Owner

A248 commented Oct 2, 2023

LibertyBans Version

1.1.0-RC1

I have confirmed that ...

  • LibertyBans is up to date
  • No similar issue has been reported

Platform

Spigot/Paper

Description

The documentation is sparse as to when plugin messages can be sent. However, some information suggests that plugin messages should be sent a little bit later than the join event. It would be worth investigating, at the least -- the feature seemed to work in manual testing, but maybe not for all versions.

Sponge already seems to require a delay in its ServerSideConnectionEvent.Join. A delay would thus seem a reasonable precaution on Bukkit.

@A248 A248 added the bug Interferes with efficient operation label Oct 2, 2023
A248 added a commit that referenced this issue Mar 8, 2024
Channel detection is now re-fixed. After hours of testing,
  hopefully this will be the last time.
@A248 A248 closed this as completed Mar 10, 2024
@A248 A248 added this to the 1.1.0 milestone Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Interferes with efficient operation
Projects
None yet
Development

No branches or pull requests

1 participant