Skip to content

Missing "external" services/plugins will lead to crash of DataEngine#20

Merged
mm-kgi merged 2 commits intodevelopfrom
107-external-service-missing-crash-dataengine
Jan 23, 2026
Merged

Missing "external" services/plugins will lead to crash of DataEngine#20
mm-kgi merged 2 commits intodevelopfrom
107-external-service-missing-crash-dataengine

Conversation

@mm-kgi
Copy link
Contributor

@mm-kgi mm-kgi commented Jan 22, 2026

  • Refactor SyncShellDescriptorsAsync to log errors and return instead of throwing the exceptions

@mm-kgi mm-kgi requested a review from mm-asha January 22, 2026 10:49
@mm-kgi mm-kgi self-assigned this Jan 22, 2026
@HolgerSantelmann HolgerSantelmann self-requested a review January 23, 2026 12:10
Copy link

@HolgerSantelmann HolgerSantelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TestCase] Verify that DataEngine remains operational and does not crash when an external plugin becomes unavailable during runtime
#368

@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions
Copy link

Test & Coverage Report

Test Results Summary

Metric Count
✅ Passed 460
❌ Failed 0
⏭️ Skipped 0

View Detailed Test Results


Code Coverage

Unit Tests Coverage

Package Line Rate Branch Rate Complexity Health
AAS.TwinEngine.DataEngine 90% 80% 1188
Summary 90% (2049 / 2273) 80% (836 / 1044) 1188

Minimum allowed line rate is 80%

Module Tests Coverage

Package Line Rate Branch Rate Complexity Health
AAS.TwinEngine.DataEngine 56% 40% 1188
Summary 56% (1279 / 2273) 40% (421 / 1044) 1188

@mm-kgi mm-kgi merged commit 35e0d20 into develop Jan 23, 2026
7 checks passed
mm-psy referenced this pull request in mm-psy/AAS.TwinEngine.DataEngine Jan 23, 2026
* Add dependency-review (#3)

* Add dependency-review

* Fix branch

* Add Scorecard supply-chain security (#2)

* Create docker-publish.yml (#7)

* Create dotnet (#6)

* Create dotnet.yml

* Add comment

* Test

* Test

* Enhance CI workflow with code coverage reporting and PR comments

* Fix wrong test run

* Refactor CI workflow to improve test result handling and add module test execution

* Enhance CI workflow by combining test and coverage reports, and updating paths for coverage files

* Enhance Submodel Element request handling(#8)

* Add dependabot-version-updates (#4)

* Add dependabot-version-updates

* Enhancement of DataEngine Implementation  (#12)

* Added example folder With Dpp-plugin  (#13)

* Restructure Dockerfile for improved build process and clarity (#14)

* Added Test Plugin and Example for 3 submodels using Test plugin (#11)

* #182: Test plugin review results (#17)

* #182: Rename of folder

* #182: Refinement of apiCollection Readmes and environments

* #182: Also rename of Aas.TwinEngine.Plugin.TestPlugin to AAS.TwinEngine.Plugin.TestPlugin in files

* Remove obsolete test project files and add new project files for Plugin testing

* Remove obsolete test project files and add new project files for Plugin testing

* #182: Rename of projects

* #182: Readme refined

* #182: Refinement of readme

* #182: Icons removed from readme

---------

Co-authored-by: Kevalkumar <kgi@mm-software.com>

* Add codeql (#5)

* Create codeql.yml

* Update branches

* Enhancement of DataEngine Implementation (#18)

* Add hotfix develop release branches to actions (#15)

* Update dependency-review.yml

* Update dotnet.yml

* Update docker-publish.yml

* Update docker-publish.yml to refine branch triggers and enhance Docker metadata extraction

* Fix image name

* Add manually trigger a workflow

* #257: Enhancement TestPlugin to verify access SubmodelElement inside a SubmodelCollection within a SubmodelList (#19)

* README.md with detailed DataEngine overview and feature descriptions (#22)

* Refactor SyncShellDescriptorsAsync to log errors and return instead of throwing exceptions for null checks (#20)

---------

Co-authored-by: Kevalkumar Ghelani <kgi@mm-software.com>
Co-authored-by: Hardi Shah <hsh@mm-software.com>
Co-authored-by: mm-hsn <hsn@mm-software.com>
@mm-hsh mm-hsh deleted the 107-external-service-missing-crash-dataengine branch January 27, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments