#387 - Fix : TestPlugin : 404 - file entries#34
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR fixes 404 errors for file submodel elements (CompanyLogo, MarkingFile, and ArbitraryFile) by replacing placeholder file references with actual URLs pointing to resources in the GitHub repository. Additionally, it updates example URLs and theme colors.
Changes:
- Replaced placeholder file paths with GitHub raw content URLs for file submodel elements
- Updated example.com URLs to actual mm-software.com domain URLs
- Corrected PRIMARY_DARK_COLOR and PRIMARY_LIGHT_COLOR values in docker-compose.yml
- Removed redundant directory change instruction from README
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| source/AAS.TwinEngine.Plugin.TestPlugin/Example/plugin/mock-submodel-data.json | Updated file references and contact information URLs to use actual GitHub and domain URLs |
| source/AAS.TwinEngine.Plugin.TestPlugin/Example/plugin/mock-metadata.json | Replaced external CDN image URLs with GitHub repository URLs for product thumbnails |
| source/AAS.TwinEngine.Plugin.TestPlugin/Example/docker-compose.yml | Swapped PRIMARY_DARK_COLOR and PRIMARY_LIGHT_COLOR values |
| source/AAS.TwinEngine.Plugin.TestPlugin/Data/mock-submodel-data.json | Updated file references and contact information URLs (mirrors Example/plugin version) |
| source/AAS.TwinEngine.Plugin.TestPlugin/Data/mock-metadata.json | Replaced external CDN image URLs with GitHub repository URLs (mirrors Example/plugin version) |
| example/README.md | Removed redundant cd command from installation instructions |
Comments suppressed due to low confidence (1)
source/AAS.TwinEngine.Plugin.TestPlugin/Data/mock-submodel-data.json:1
- The URL appears to have '01' appended to the filename 'checkmark.png01', which likely does not exist. This should probably be 'checkmark.png' or a different valid file.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
source/AAS.TwinEngine.Plugin.TestPlugin/Example/plugin/mock-submodel-data.json
Outdated
Show resolved
Hide resolved
…bmodel-data.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Test & Coverage ReportTest Results Summary
Code CoverageUnit Tests Coverage
Minimum allowed line rate is Module Tests Coverage
|
mcn-mm
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue with file submodelElement :