Skip to content

Comments

#121- Add default values for configuration properties and update docker-compose environment variables#35

Merged
mm-hsh merged 6 commits intodevelopfrom
feature/121-environment-variable
Feb 16, 2026
Merged

#121- Add default values for configuration properties and update docker-compose environment variables#35
mm-hsh merged 6 commits intodevelopfrom
feature/121-environment-variable

Conversation

@mm-hsh
Copy link
Contributor

@mm-hsh mm-hsh commented Feb 3, 2026

No description provided.

Moved configuration defaults from environment variables to code for key settings, reducing external config requirements.
Set default localhost URLs for AasEnvironmentConfig URI properties to simplify local development.
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Default values for several URI properties in AasEnvironmentConfig have been removed. These properties are now initialized with null! and must be explicitly set elsewhere, rather than relying on hardcoded localhost or domain URLs.
@mm-hsh mm-hsh marked this pull request as ready for review February 3, 2026 07:28
@mm-hsh mm-hsh requested a review from mm-asha February 3, 2026 07:28
@mm-hsh mm-hsh force-pushed the feature/121-environment-variable branch from 03c2d42 to 0675fd3 Compare February 4, 2026 08:39
@github-actions
Copy link

Test & Coverage Report

Test Results Summary

Metric Count
✅ Passed 460
❌ Failed 0
⏭️ Skipped 0

View Detailed Test Results


Code Coverage

Unit Tests Coverage

Package Line Rate Branch Rate Complexity Health
AAS.TwinEngine.DataEngine 90% 80% 1188
Summary 90% (2051 / 2275) 80% (835 / 1044) 1188

Minimum allowed line rate is 80%

Module Tests Coverage

Package Line Rate Branch Rate Complexity Health
AAS.TwinEngine.DataEngine 56% 40% 1188
Summary 56% (1278 / 2275) 40% (421 / 1044) 1188

@sonarqubecloud
Copy link

@mm-hsh mm-hsh merged commit 9991213 into develop Feb 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants