feat: Update Docker publish workflow for tag handling#39
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Removed an empty line before the Export Application SBOM step.
…e branches (exclude tags and PRs)
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Author
|
Copy of #32. QA was missing |
mm-mse
approved these changes
Feb 5, 2026
HolgerSantelmann
left a comment
HolgerSantelmann
left a comment
There was a problem hiding this comment.
I created test case #452 and attached. Also I attached the bug
[Bug] Manual trigger of DOCKER build leads to error during Trivy SBOM generation #406
For test case execution I forked the repository:
For the feature branch I need to set manually the write permission for package creation.
Then an image could be created successfully.
But:
Acceptance criteria of bug mention the following:
- Image is tagged appropriately for manual build
Is the tag for manual execution missing?
Contributor
Author
We don't have a specific "manual" tag anymore. It is now a generic tag. |
HolgerSantelmann
approved these changes
Feb 6, 2026
HolgerSantelmann
left a comment
HolgerSantelmann
left a comment
There was a problem hiding this comment.
[TestCase] Verify that manual trigger of DOCKER build does not lead to error (DataEngine) #452
passed
Test & Coverage ReportTest Results Summary
Code CoverageUnit Tests Coverage
Minimum allowed line rate is Module Tests Coverage
|
mm-psy
referenced
this pull request
in mm-psy/AAS.TwinEngine.DataEngine
Feb 10, 2026
* Resolved container app errors related to AAS registry endpoint (#33) * Fix : TestPlugin : 404 - file entries (#34) * feat: Update Docker publish workflow for tag handling (#32) * Update Docker publish workflow for tag handling * Update .github/workflows/docker-publish.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Clean up docker-publish.yml by removing empty line Removed an empty line before the Export Application SBOM step. * Add comment for priority setting * Add clarifying comment to Docker tag rule for non-develop, non-release branches (exclude tags and PRs) * Update tag extraction for Trivy scanning to prioritize highest tag --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revert "feat: Update Docker publish workflow for tag handling (#32)" (#38) This reverts commit a36238e. * feat: Pin nugetcommand (#36) * feat: Update Docker publish workflow for tag handling (#39) * Update Docker publish workflow for tag handling * Update .github/workflows/docker-publish.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Clean up docker-publish.yml by removing empty line Removed an empty line before the Export Application SBOM step. * Add comment for priority setting * Add clarifying comment to Docker tag rule for non-develop, non-release branches (exclude tags and PRs) * Update tag extraction for Trivy scanning to prioritize highest tag --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * #129: Created initial structure of C# Playwright API tests for TestPlugin * #129: Added Environment.GetEnvironmentVariable("BASE_URL") to ApiTestBase * #129: FluentAssertions removed and replaced usage by xunit Assert * #129: Health test added * #129: Unneeded configuration removed * #129: Refinment of tests * #129: Refinement of rest api test * #129: String comparison refined * #129: Throws argument null excepion of response is null * #129: Set copy always for GetSubmodelDescriptorById_Reliability_Expected.json * workflow_dispatch added to dependency-review (#41) * #185: Workflow for plaaywright tests added * Revert "workflow_dispatch added to dependency-review (#41)" (#43) This reverts commit 4e5d5fc. * fix: Update condition for publishing Playwright test results --------- Co-authored-by: Kevalkumar Ghelani <kgi@mm-software.com> Co-authored-by: Hardi Shah <hsh@mm-software.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: mm-hsn <hsn@mm-software.com>
mm-psy
referenced
this pull request
in mm-psy/AAS.TwinEngine.DataEngine
Feb 10, 2026
* Add dependency-review (#3) * Add dependency-review * Fix branch * Add Scorecard supply-chain security (#2) * Create docker-publish.yml (#7) * Create dotnet (#6) * Create dotnet.yml * Add comment * Test * Test * Enhance CI workflow with code coverage reporting and PR comments * Fix wrong test run * Refactor CI workflow to improve test result handling and add module test execution * Enhance CI workflow by combining test and coverage reports, and updating paths for coverage files * Enhance Submodel Element request handling(#8) * Add dependabot-version-updates (#4) * Add dependabot-version-updates * Enhancement of DataEngine Implementation (#12) * Added example folder With Dpp-plugin (#13) * Restructure Dockerfile for improved build process and clarity (#14) * Added Test Plugin and Example for 3 submodels using Test plugin (#11) * #182: Test plugin review results (#17) * #182: Rename of folder * #182: Refinement of apiCollection Readmes and environments * #182: Also rename of Aas.TwinEngine.Plugin.TestPlugin to AAS.TwinEngine.Plugin.TestPlugin in files * Remove obsolete test project files and add new project files for Plugin testing * Remove obsolete test project files and add new project files for Plugin testing * #182: Rename of projects * #182: Readme refined * #182: Refinement of readme * #182: Icons removed from readme --------- Co-authored-by: Kevalkumar <kgi@mm-software.com> * Add codeql (#5) * Create codeql.yml * Update branches * Enhancement of DataEngine Implementation (#18) * Add hotfix develop release branches to actions (#15) * Update dependency-review.yml * Update dotnet.yml * Update docker-publish.yml * Update docker-publish.yml to refine branch triggers and enhance Docker metadata extraction * Fix image name * Add manually trigger a workflow * #257: Enhancement TestPlugin to verify access SubmodelElement inside a SubmodelCollection within a SubmodelList (#19) * README.md with detailed DataEngine overview and feature descriptions (#22) * Refactor SyncShellDescriptorsAsync to log errors and return instead of throwing exceptions for null checks (#20) * Generate SBOM for Container & application (#23) * Generate SBOM for application dependencies * Generate Container SBOM and extract App SBOM. Push both to Artifacts. * Pin actions by hash and ensure app path casing aligns with Dockerfile * Exclude SBOM generation from PR runs * Add groups dependabot (#24) * Enhance example-Docker setup (#16) * Add manual trigger capability to .NET pipeline (#21) * Merge main branch and resolved the security issue (#27) * Dev fix trivy (#22) * Fix image reference extraction for Trivy SBOM generation in Docker publish workflow * Add step to extract first image tag for Trivy scanning in Docker publish workflow * Dev fix trivy + tag rework (#23) * Fix image reference extraction for Trivy SBOM generation in Docker publish workflow * Add step to extract first image tag for Trivy scanning in Docker publish workflow * Fix manual trigger value format in Docker publish workflow * Fix tag generation logic for Docker image based on branch conditions * Enhance tag generation logic for Docker image by adding priority to develop branch tags * Fix tag generation logic for non-develop and non-release branches in Docker publish workflow * Psy test playwright (#35) * Resolved container app errors related to AAS registry endpoint (#33) * Fix : TestPlugin : 404 - file entries (#34) * feat: Update Docker publish workflow for tag handling (#32) * Update Docker publish workflow for tag handling * Update .github/workflows/docker-publish.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Clean up docker-publish.yml by removing empty line Removed an empty line before the Export Application SBOM step. * Add comment for priority setting * Add clarifying comment to Docker tag rule for non-develop, non-release branches (exclude tags and PRs) * Update tag extraction for Trivy scanning to prioritize highest tag --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revert "feat: Update Docker publish workflow for tag handling (#32)" (#38) This reverts commit a36238e. * feat: Pin nugetcommand (#36) * feat: Update Docker publish workflow for tag handling (#39) * Update Docker publish workflow for tag handling * Update .github/workflows/docker-publish.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Clean up docker-publish.yml by removing empty line Removed an empty line before the Export Application SBOM step. * Add comment for priority setting * Add clarifying comment to Docker tag rule for non-develop, non-release branches (exclude tags and PRs) * Update tag extraction for Trivy scanning to prioritize highest tag --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * #129: Created initial structure of C# Playwright API tests for TestPlugin * #129: Added Environment.GetEnvironmentVariable("BASE_URL") to ApiTestBase * #129: FluentAssertions removed and replaced usage by xunit Assert * #129: Health test added * #129: Unneeded configuration removed * #129: Refinment of tests * #129: Refinement of rest api test * #129: String comparison refined * #129: Throws argument null excepion of response is null * #129: Set copy always for GetSubmodelDescriptorById_Reliability_Expected.json * workflow_dispatch added to dependency-review (#41) * #185: Workflow for plaaywright tests added * Revert "workflow_dispatch added to dependency-review (#41)" (#43) This reverts commit 4e5d5fc. * fix: Update condition for publishing Playwright test results --------- Co-authored-by: Kevalkumar Ghelani <kgi@mm-software.com> Co-authored-by: Hardi Shah <hsh@mm-software.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: mm-hsn <hsn@mm-software.com> --------- Co-authored-by: Kevalkumar Ghelani <kgi@mm-software.com> Co-authored-by: Hardi Shah <hsh@mm-software.com> Co-authored-by: mm-hsn <hsn@mm-software.com> Co-authored-by: rkg-mm <12029804+rkg-mm@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes refine the tagging strategy for different Git branch types and fix an issue where Trivy scanning was failing due to being passed multiple image tags.