398 load multiple observation files in sequence #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plugins allow this first
…re in the file menu vs the file chooser
…in file chooser list
…use in error handling
mpyat2
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
Hi @dbenn , it's a great improvement. For big data sequences (like TESS), loading several files at once is much faster than additive loading (when we use additive loading, adding each new bunch of data takes a long time, probably because of relocation of existing data or something similar).
Thank you for the implementation!
In the future, it will be useful to add this functionality to other plugins. However, being under pressure from the upcoming release, it would be wiser to postpone other changes.
It seems it works as expected.
|
Thank you @mpyat2 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mpyat2, please see what I've written in the issue and let me know if you have questions.
I may add the multiple file feature to other plugins before we close this but for now it's just the infrastructure and TESS-common-code plugins. Indeed, given a Jan 31-ish release deadline due to Auth0 (more like Feb 1 or 2 I'd say), there may not be time for much more.