-
Notifications
You must be signed in to change notification settings - Fork 14
Add support for AggregateException in SkippableFact #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AArnott <3548+AArnott@users.noreply.github.com>
Co-authored-by: AArnott <3548+AArnott@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Support AggregateExceptions?
Add support for AggregateException in SkippableFact
Jun 11, 2025
This was referenced Dec 29, 2025
CurtHagenlocher
pushed a commit
to apache/arrow-dotnet
that referenced
this pull request
Dec 29, 2025
Updated [Xunit.SkippableFact](https://github.com/AArnott/Xunit.SkippableFact) from 1.5.23 to 1.5.61. <details> <summary>Release notes</summary> _Sourced from [Xunit.SkippableFact's releases](https://github.com/AArnott/Xunit.SkippableFact/releases)._ ## 1.5.61 ## What's Changed * Document support for class-level OS targeting by @AArnott in AArnott/Xunit.SkippableFact#50 * Add support for AggregateException in SkippableFact by @Copilot in AArnott/Xunit.SkippableFact#80 * Fix wrong failed state for rider by @JKamsker in AArnott/Xunit.SkippableFact#105 ## New Contributors * @renovate[bot] made their first contribution in AArnott/Xunit.SkippableFact#64 * @github-actions[bot] made their first contribution in AArnott/Xunit.SkippableFact#72 * @Copilot made their first contribution in AArnott/Xunit.SkippableFact#80 * @JKamsker made their first contribution in AArnott/Xunit.SkippableFact#105 **Full Changelog**: AArnott/Xunit.SkippableFact@v1.5.23...v1.5.61 Commits viewable in [compare view](AArnott/Xunit.SkippableFact@v1.5.23...v1.5.61). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Dec 29, 2025
github-merge-queue bot
pushed a commit
to microsoft/typechat.net
that referenced
this pull request
Dec 29, 2025
Updated [Xunit.SkippableFact](https://github.com/AArnott/Xunit.SkippableFact) from 1.5.23 to 1.5.61. <details> <summary>Release notes</summary> _Sourced from [Xunit.SkippableFact's releases](https://github.com/AArnott/Xunit.SkippableFact/releases)._ ## 1.5.61 ## What's Changed * Document support for class-level OS targeting by @AArnott in AArnott/Xunit.SkippableFact#50 * Add support for AggregateException in SkippableFact by @Copilot in AArnott/Xunit.SkippableFact#80 * Fix wrong failed state for rider by @JKamsker in AArnott/Xunit.SkippableFact#105 ## New Contributors * @renovate[bot] made their first contribution in AArnott/Xunit.SkippableFact#64 * @github-actions[bot] made their first contribution in AArnott/Xunit.SkippableFact#72 * @Copilot made their first contribution in AArnott/Xunit.SkippableFact#80 * @JKamsker made their first contribution in AArnott/Xunit.SkippableFact#105 **Full Changelog**: AArnott/Xunit.SkippableFact@v1.5.23...v1.5.61 Commits viewable in [compare view](AArnott/Xunit.SkippableFact@v1.5.23...v1.5.61). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Dec 29, 2025
CurtHagenlocher
pushed a commit
to apache/arrow-adbc
that referenced
this pull request
Jan 2, 2026
Updated [Xunit.SkippableFact](https://github.com/AArnott/Xunit.SkippableFact) from 1.5.23 to 1.5.61. <details> <summary>Release notes</summary> _Sourced from [Xunit.SkippableFact's releases](https://github.com/AArnott/Xunit.SkippableFact/releases)._ ## 1.5.61 ## What's Changed * Document support for class-level OS targeting by @AArnott in AArnott/Xunit.SkippableFact#50 * Add support for AggregateException in SkippableFact by @Copilot in AArnott/Xunit.SkippableFact#80 * Fix wrong failed state for rider by @JKamsker in AArnott/Xunit.SkippableFact#105 ## New Contributors * @renovate[bot] made their first contribution in AArnott/Xunit.SkippableFact#64 * @github-actions[bot] made their first contribution in AArnott/Xunit.SkippableFact#72 * @Copilot made their first contribution in AArnott/Xunit.SkippableFact#80 * @JKamsker made their first contribution in AArnott/Xunit.SkippableFact#105 **Full Changelog**: AArnott/Xunit.SkippableFact@v1.5.23...v1.5.61 Commits viewable in [compare view](AArnott/Xunit.SkippableFact@v1.5.23...v1.5.61). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
CurtHagenlocher
pushed a commit
to adbc-drivers/bigquery
that referenced
this pull request
Jan 2, 2026
Updated [Xunit.SkippableFact](https://github.com/AArnott/Xunit.SkippableFact) from 1.5.23 to 1.5.61. <details> <summary>Release notes</summary> _Sourced from [Xunit.SkippableFact's releases](https://github.com/AArnott/Xunit.SkippableFact/releases)._ ## 1.5.61 ## What's Changed * Document support for class-level OS targeting by @AArnott in AArnott/Xunit.SkippableFact#50 * Add support for AggregateException in SkippableFact by @Copilot in AArnott/Xunit.SkippableFact#80 * Fix wrong failed state for rider by @JKamsker in AArnott/Xunit.SkippableFact#105 ## New Contributors * @renovate[bot] made their first contribution in AArnott/Xunit.SkippableFact#64 * @github-actions[bot] made their first contribution in AArnott/Xunit.SkippableFact#72 * @Copilot made their first contribution in AArnott/Xunit.SkippableFact#80 * @JKamsker made their first contribution in AArnott/Xunit.SkippableFact#105 **Full Changelog**: AArnott/Xunit.SkippableFact@v1.5.23...v1.5.61 Commits viewable in [compare view](AArnott/Xunit.SkippableFact@v1.5.23...v1.5.61). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for handling
AggregateExceptionin Xunit.SkippableFact. When a test throws anAggregateExceptioncontaining skip exceptions, the test will now be properly skipped instead of failing.Problem
Previously, tests that threw
AggregateExceptioncontaining skip exceptions would fail instead of being skipped:This was particularly problematic when using
Task.WhenAllor similar patterns that aggregate multiple exceptions, where one of the exceptions was a skip condition.Solution
The implementation adds a new case to
SkippableTestMessageBus.QueueMessage()that:System.AggregateExceptionExamples
All of these scenarios now work correctly:
Implementation Details
ThrowsExceptionhandling approachThe implementation follows the requirement to skip if ANY inner exception is a skip exception (not requiring ALL to be skip exceptions), which aligns with typical test failure scenarios.
Fixes #31.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.