Merge pull request microsoft#992 from microsoft/dependabot/nuget/Visu…

…alStudioThreadingVersion-17.9.28 Bump VisualStudioThreadingVersion from 17.8.14 to 17.9.28
AArnott · Mar 5, 2024 · 5f21ac8 · 5f21ac8
2 parents 5efdbec + 82ff275
commit 5f21ac8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -7,7 +7,7 @@
 
     <MessagePackVersion>2.5.108</MessagePackVersion>
     <MicroBuildVersion>2.0.149</MicroBuildVersion>
-    <VisualStudioThreadingVersion>17.8.14</VisualStudioThreadingVersion>
+    <VisualStudioThreadingVersion>17.9.28</VisualStudioThreadingVersion>
   </PropertyGroup>
   <ItemGroup>
     <PackageVersion Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.13.10" />

diff --git a/src/StreamJsonRpc/JsonRpc.cs b/src/StreamJsonRpc/JsonRpc.cs
@@ -506,7 +506,9 @@ public Task Completion
     {
         get
         {
+#pragma warning disable VSTHRD003 // Avoid awaiting foreign Tasks
             return this.completionSource.Task;
+#pragma warning restore VSTHRD003 // Avoid awaiting foreign Tasks
         }
     }
 

diff --git a/src/StreamJsonRpc/MessageHandlerBase.cs b/src/StreamJsonRpc/MessageHandlerBase.cs
@@ -261,7 +261,9 @@ public virtual async Task DisposeAsync()
             }
 
             // Wait for completion to actually complete, and re-throw any exceptions.
+#pragma warning disable VSTHRD003 // Avoid awaiting foreign Tasks
             await this.Completion.ConfigureAwait(false);
+#pragma warning restore VSTHRD003 // Avoid awaiting foreign Tasks
 
             this.Dispose(true);
         }

diff --git a/src/StreamJsonRpc/Reflection/MessageFormatterEnumerableTracker.cs b/src/StreamJsonRpc/Reflection/MessageFormatterEnumerableTracker.cs
@@ -271,7 +271,9 @@ public async ValueTask<object> GetNextValuesAsync(CancellationToken cancellation
                         if (this.readAheadElements.Completion.IsCompleted)
                         {
                             // Rethrow any exceptions.
+#pragma warning disable VSTHRD003 // Avoid awaiting foreign Tasks
                             await this.readAheadElements.Completion.ConfigureAwait(false);
+#pragma warning restore VSTHRD003 // Avoid awaiting foreign Tasks
                             finished = true;
                         }
                     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -506,7 +506,9 @@ public Task Completion @@
         {
             get
             {
+    #pragma warning disable VSTHRD003 // Avoid awaiting foreign Tasks
                 return this.completionSource.Task;
+    #pragma warning restore VSTHRD003 // Avoid awaiting foreign Tasks
             }
         }
@@ Expand Down @@