Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMR results mixed #81

Draft
wants to merge 79 commits into
base: main
Choose a base branch
from
Draft

PMR results mixed #81

wants to merge 79 commits into from

Conversation

akhuoa
Copy link
Member

@akhuoa akhuoa commented Jul 22, 2024 •
edited
Loading

This PR is for the replacement of #80.
Plus, "Flatmap" and "Simulation" buttons in the PMR card.

PMR feature

To show PMR results and PMR in Data type in filters,
withPMRData flag must be set to true in Sidebar component.

Tehsurfer and others added 30 commits September 29, 2023 13:38
@Tehsurfer
Add pmr mode and selector to sidebar
8c29af0
@Tehsurfer
Add sparc datasets
fcdc813
@Tehsurfer
Add missing files
3f4c62e
@Tehsurfer
Catch up with main branch
b568aeb
@akhuoa
Update PMR test data and UI
7dd9295
@akhuoa
Update sample data
757ccfe
@akhuoa
Refactor PMR Card
4979c42
@akhuoa
Move PMR sample data to json file and fetch
06792ac
@Tehsurfer
Start using the flatmap server for pmr queries
1e54fca
@Tehsurfer
Add processing for pmr results
27525b2
@Tehsurfer
Fix pmr cards by only using metadata from pmr queries
772474e
@Tehsurfer
Remove duplicate results
5555ab8
@Tehsurfer
Add ability to filter on features
e410efe
@Tehsurfer
Add ability to search on filters in pmr
95a6ed4
@Tehsurfer
Hook pmr up to results
f6a1d0e
@Tehsurfer
Attempt at pagination
40d9d4c
@Tehsurfer
Results now in same pane, but pagination not perfect and numresults s…
c3f9272 
…till seperate
@akhuoa
Add PMR checkbox under Data type filters
4865244
@Tehsurfer
Attempt at variable results ratio
b87cadc
@akhuoa
Add PMR search only function
701d918
@akhuoa
Merge branch 'pmr-results-mixed' of github.com:Tehsurfer/map-sidebar …
b1e11c6 
…into pmr-results-mixed
@akhuoa
Remove unnecessary variable
9f0cff5
@akhuoa
Add dataset-card hover event
f65beb9
@akhuoa
Merge branch 'main' into pmr-results-mixed-updated
ffe7590
@akhuoa
Merge branch 'main' into pmr-results-mixed-updated
654b292
@akhuoa
Link PMR from filter to show PMR results
86b18e4
@Tehsurfer
Finish getting mixed results to work
e04c2c8
@Tehsurfer
Merge branch 'pmr-results-mixed' into pmr-results-mixed-updated
ee0b168
@Tehsurfer
Merge pull request #4 from akhuoa/pmr-results-mixed-updated
3e5047a 
Pmr results mixed updated
@Tehsurfer
Fix the pmr only button and add text search
409d9dc
@alan-wu alan-wu mentioned this pull request Jul 22, 2024
Closed
This was referenced Jul 23, 2024
Closed
Closed
akhuoa added 16 commits July 23, 2024 13:01
alan-wu
alan-wu requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, need some minor adjustment.

src/algolia/algolia.js Outdated Show resolved Hide resolved
src/algolia/algolia.js Show resolved Hide resolved
src/components/SidebarContent.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-wu alan-wu alan-wu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akhuoa @alan-wu @Tehsurfer