Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Default to the device pixel ratio #304

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ueman
Copy link
Contributor

@ueman ueman commented Oct 2, 2024

Resolves #205

Description

The pixel ratio will no longer default to 1. Instead, it defaults to the current device' pixel ratio. This should increase the screenshot fidelity.

Checklist

  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added code (documentation) comments where necessary.
  • I have updated/added relevant examples in example or documentation.

Breaking Change?

Technically, this is a breaking change since it modifies existing behavior. It's not a breaking change in terms of the API. Since it should have only positive effects and no negative effects,
I would say this can be considered a non-breaking change.

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Copy link

docs-page bot commented Oct 2, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/abausg/home_widget~304

Documentation is deployed and generated using docs.page.

@ueman ueman marked this pull request as ready for review October 2, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pixelRatio for rendered Flutter widget should default to the device's pixel ratio
1 participant