Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#154] Paths value filter #156

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Conversation

ABridoux
Copy link
Owner

@ABridoux ABridoux commented Feb 4, 2021

Value predicate in listPaths function

  • Specify a predicate on the value. Possibility to specify several predicates to target different types of values (e.g. string, int).

  • Optimisation to cache a mismatched type if an expression already mismatched it.

  • Refactored PathsFilter

Command-line paths command updated with predicates

The paths command now offers the possibility to specify several predicate to filter the value.

Closes #154

Alexis Bridoux added 2 commits February 3, 2021 10:27
- Specify a predicate on the value. Possibility to specify several predicates to target different types of values (e.g. string, int).
- Optimisation to cache a mismatched type if an expression already mismatched it.
@ABridoux ABridoux linked an issue Feb 4, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #156 (be4ea79) into develop (cfbad43) will increase coverage by 0.27%.
The diff coverage is 83.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #156      +/-   ##
===========================================
+ Coverage    80.48%   80.75%   +0.27%     
===========================================
  Files           35       36       +1     
  Lines         2075     2162      +87     
===========================================
+ Hits          1670     1746      +76     
- Misses         405      416      +11     
Impacted Files Coverage Δ
...es/Scout/Definitions/PathExplorer+Extensions.swift 67.24% <0.00%> (ø)
Sources/Scout/Definitions/PathExplorerError.swift 0.00% <0.00%> (ø)
.../Serialization/PathExplorerSerialization+Add.swift 100.00% <ø> (ø)
Sources/Scout/Definitions/KeyAllowedType.swift 73.91% <64.70%> (-20.21%) ⬇️
...erialization/PathExplorerSerialization+Paths.swift 58.82% <80.00%> (-10.75%) ⬇️
...ut/Implementations/XML/PathExplorerXML+Paths.swift 51.85% <80.00%> (-12.60%) ⬇️
Sources/Scout/Definitions/PathsFilter.swift 91.78% <91.78%> (ø)
Sources/Scout/Definitions/Path.swift 78.15% <100.00%> (+1.16%) ⬆️
...ources/ScoutCLT/Extensions/String+Extensions.swift 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfbad43...dbcd809. Read the comment docs.

The paths command now offers the possibility to specify several predicate to filter the value.
@ABridoux ABridoux force-pushed the feature/154-paths-value-filter branch from be4ea79 to dbcd809 Compare February 4, 2021 09:57
@ABridoux ABridoux merged commit fae2bab into develop Feb 4, 2021
@ABridoux ABridoux deleted the feature/154-paths-value-filter branch February 4, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When listing paths, filter value with a predicate
1 participant