Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preindustrial: update to model version 2024.12.0 #115

Conversation

blimlim
Copy link

@blimlim blimlim commented Dec 13, 2024

This PR updates the model version to 2024.12.0 in order to include the UM orbital parameter code changes. It closes the preindustrial half of #114.

@blimlim
Copy link
Author

blimlim commented Dec 13, 2024

! test repro

@blimlim
Copy link
Author

blimlim commented Dec 15, 2024

!test repro

@ACCESS-NRI ACCESS-NRI deleted a comment from github-actions bot Dec 15, 2024
Copy link

✅ The Bitwise Reproducibility Check Succeeded ✅

When comparing:

  • 114-preindustrial-model-version-2024.12.0 (checksums created using commit d4727ea), against
  • dev-preindustrial+concentrations (checksums in commit dfc9d94)
Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-esm1.5-configs/d4727ea793308edde9de10f60846eebb992c73a0, and the test results at https://github.com/ACCESS-NRI/access-esm1.5-configs/runs/34443890376.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-esm1.5-configs/actions/runs/12343116392/artifacts/2323579143.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-esm1.5-configs/tree/dfc9d94efec63e6654ef4793f0eed959c77c1291/testing/checksum

Copy link
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I assume you were expecting it to reproduce?

@blimlim
Copy link
Author

blimlim commented Dec 15, 2024

Thanks @CodeGat! Yeah! we're expecting it to still reproduce with these changes

@blimlim blimlim merged commit 6651697 into dev-preindustrial+concentrations Dec 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants