Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using HDF5 version 1.14.3 #34

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

penguian
Copy link
Contributor

Closes #33 . Tested by appending

        depends_on("hdf5@1.14.3")

to

     with when("@access-esm1.5"):
         depends_on("oasis3-mct@access-esm1.5")

in https://github.com/ACCESS-NRI/spack-packages/blob/main/packages/mom5/package.py . Running

$ spack install mom5@access-esm1.5%intel@19.0.5.281 arch=linux-rocky8-x86_64

then results in

==> Error: concretization failed for the following reasons:

   1. FPE bug in hdf5@1.14.3 is not patched in Spack versions earlier than v0.22

@penguian penguian requested a review from harshula June 13, 2024 07:22
@penguian penguian self-assigned this Jun 13, 2024
@penguian penguian linked an issue Jun 13, 2024 that may be closed by this pull request
@harshula
Copy link
Collaborator

Hi @penguian , For v0.20 and v0.22, keep the symlink to the unmodified packages.yaml from common. For v0.21, replace the symlink with the modified packages.yaml.

@penguian penguian force-pushed the 33-avoid-using-hdf5-1-14-3 branch from 8ea1d9a to d871aba Compare June 14, 2024 04:29
@penguian
Copy link
Contributor Author

The one_of syntax is obsolete as of Spack v0.22, but it is described here:
https://spack.readthedocs.io/en/v0.22.0/packages_yaml.html#conflicts-and-strong-preferences
Note that the prefer: and conflict: sections are new as of Spack v0.22.
See spack/spack#41832 for the relevant pull request.

Copy link
Collaborator

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thanks!

@penguian penguian force-pushed the 33-avoid-using-hdf5-1-14-3 branch from d871aba to 3496be3 Compare June 14, 2024 05:18
@penguian penguian merged commit 203b80c into main Jun 14, 2024
@penguian penguian deleted the 33-avoid-using-hdf5-1-14-3 branch June 14, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Avoid using hdf5-1.14.3
2 participants