.NET Entity Framework Core 3.1 support (attempt #2) #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuff
Mag-nus
changed the title
Mag-nus
changed the title
Mag-nus
changed the title
LtRipley36706
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the biggest breaking changes in EF Core 3.0+ is existing LINQ queries like .Include() are no longer evaluated client-side. They now can result in explosive joins. This issue is documented here: dotnet/efcore#18022
For the above reason, many heavy .Include() queries have now been rewritten per the updated advice from one of the core EF Contributors using this example: https://gist.github.com/smitpatel/d4cb3619e5b33e8d9ea24d3f2a88333a
This PR needs some testing on development servers.
I do NOT recommend this be run on production yet.