Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory leak fix for Collective + minor changes #524

Merged
merged 7 commits into from
Jul 21, 2024

Conversation

jchung01
Copy link
Contributor

Main additions/adjustments for this PR:

  • Adds a fix for a memory leak with the Collective mod where maps were still holding onto WorldServers even after unload, similar to Blood Magic.
  • Clean up Thermal Expansion monoculture tweak by using IItemStack for proper Set functionality.
  • Remove some unnecessary code in Advent of Ascension mixin.

Alongside fixing some other minor mistakes in readme, configs, deobf mixin names.
Also disables Jabel from new buildscript for now, it seems to make IntelliJ forget how to auto-complete Forge annotations, but feel free to enable it if you want to use modern Java syntax.

Copy link

what-the-diff bot commented Jul 21, 2024

PR Summary

  • Memory Leak Fixes Implemented
    The pull request introduces memory leak fixes for two components, namely Blood Magic and the mod "Collective". This essentially helps to improve the efficiency and performance of these modules by preventing memory wastage.

  • Settings Changes in gradle.properties
    The enableModernJavaSyntax attribute has been toggled in the gradle.properties file. This leverages different Java syntax capabilities for the project.

  • Importing and Registering new Class
    In UniversalTweaks.java, a new class called UTCollectiveEvents has been imported to be used in this script. The same class has also been registered as an event listener, thus facilitating the monitoring and handling of specific events.

  • New Configuration Category Added
    A new category named CollectiveCategory was added in UTConfigMods.java. Under this category, a new configuration option utMemoryLeakFixToggle was introduced. This allows users to enable or disable the memory leak fix.

  • Managing code dependencies
    Conditions for loading different code modules (mixins) have been revised in UTMixinLoader.java. These help ensure that only necessary modules are loaded for different situations, improving execution efficiency.

  • Methods modifications
    Several methods across different scripts have been modified in ways that improve their effectiveness or change how they function. These files include UTDSUContainerMixin.java, UTEntityFlyingCarpetMixin.java, and others.

  • Adding new labels
    New labels corresponding to the category "Collective" and relevant configuration options have been added in the en_us.lang file. This improves the user-friendliness and understanding of these new additions.

@ACGaming ACGaming merged commit a86a481 into ACGaming:main Jul 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants