Verify dependency checksums #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are you going with SHA256 here, but went with SHA512 in eclair? |
No reason I'll switch to SHA512 to be consistent with eclair. |
Dependency checksums are automatically verified when gradle/verification-metadata.xml is present.
sstone
force-pushed
the
verify-dependency-checksums
branch
from
8651590 to
c0a3d2e
Compare
|
Same comment as eclair, can you document how you initially generated those checksums, and the process to update them easily? |
Done in b1bed42. Checksums were initially generated with gradle and verified on 3 different machines (excluding github CI). |
|
What a mess!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a file that contains SHA512 checksums for all our dependencies, which will be verified during the build (checksum verification is automatically enabled when
gradle/verification-metadata.xmlis present).