Add support for PSBT roles #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement low-level support for all PSBT roles: * create * update * sign * combine * finalize * extract We don't implement any smart wallet strategy to automatically find inputs we can sign for and sign them, because it's quite involved and can be dangerous. We instead let upper layers build scripts and scriptSigs based on their knowledge of what UTXOs belong to them.
It feels more natural to have most roles (except Creator and Combiner) as function inside the case class instead of static functions in the object.
While combine is for PSBTs that describe the same transaction, it's also useful to be able to join completely independent PSBTs. This is useful in particular when one of the participants has the role of adding fees to a transaction.
This can be useful when bumping a mempool tx.
When reading a PSBT with a non-witness utxo, we must verify that it is compatible with the txIn described in the PSBT global tx.
Closed
sstone
reviewed
Oct 16, 2020
sstone
reviewed
Oct 16, 2020
sstone
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement low-level support for all PSBT roles:
We don't implement any smart wallet strategy to automatically find inputs we can sign for and sign them, because it's quite involved and can be dangerous (attackers could trick us into signing utxos we don't want to spend).
We instead let upper layers (eclair) build the scripts and witnesses based on their knowledge of what utxos belong to them.