This repository has been archived by the owner on Feb 12, 2025. It is now read-only.
Migrate Google Drive API to the REST V3 API #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Google Drive Android API that was used to upload/retrieve channels backup has been deprecated and scheduled for termination at the end of Dec, 2019. We switch to the REST V3 API which provides almost the same feature set, albeit without offline syncing. The lack of offline syncing is not an issue since we already save the channels backup on-device. see: https://developers.google.com/drive/android/deprecation * Hidden AppData folder Since Google mentions that the hidden AppData folder is going to be deprecated at some point, and since the user has already access to the actual backup file, there is no reason to hide the backups and the Google Drive backup files are now stored in a regular Drive folder that the user can freely access. Note that the app still checks for old backup that would be in this hidden AppData folder. Subsequent backups will be uploaded to the public folder. * Backup compression The backup files are now compressed before being encrypted to save some bandwidth. Fixes #208
Also fixes an issue where gdrive backup setup in newly created wallet would not complete properly.
sstone
approved these changes
Oct 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google Drive Android API that was used to upload/retrieve channels backup has been deprecated and scheduled for termination at the end of Dec, 2019. We switch to the REST V3 API which provides almost the same feature set, albeit without offline syncing. The lack of offline syncing is not an issue since we already save the channels backup on-device.
see: https://developers.google.com/drive/android/deprecation
Hidden AppData folder
Since Google mentions that the hidden AppData folder is going to be deprecated at some point, and since the user already has access to the actual backup file and can tamper with it, there is no reason to hide the backup file. Thus the Google Drive backup files are now stored in a regular Drive folder (named
eclair-mobileat the root ofMy Drive) that the user can freely access.Note that the app still checks for old backup that would be in this hidden AppData folder. Subsequent backups will be uploaded to the public folder.
Backup compression
The backup files are now compressed (using ZLIB) before being encrypted to save some bandwidth.