Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set handleCommandError to WARN #1012

Merged
merged 1 commit into from
May 27, 2019
Merged

Set handleCommandError to WARN #1012

merged 1 commit into from
May 27, 2019

Conversation

pm47
Copy link
Member

@pm47 pm47 commented May 20, 2019

Those are not fatal errors for channels.

Those are not fatal errors for channels.
@codecov-io
Copy link

Codecov Report

Merging #1012 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
+ Coverage   80.22%   80.25%   +0.02%     
==========================================
  Files          98       98              
  Lines        7546     7546              
  Branches      291      291              
==========================================
+ Hits         6054     6056       +2     
+ Misses       1492     1490       -2
Impacted Files Coverage Δ
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 83.59% <100%> (+0.48%) ⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala 74.19% <0%> (-4.31%) ⬇️
...src/main/scala/fr/acinq/eclair/router/Router.scala 85.78% <0%> (-0.95%) ⬇️
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala 97.05% <0%> (+3.92%) ⬆️
...lockchain/bitcoind/rpc/ExtendedBitcoinClient.scala 100% <0%> (+8.33%) ⬆️

@pm47 pm47 merged commit b82d721 into master May 27, 2019
@pm47 pm47 deleted the cmd-error-warn branch May 27, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants