Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter restore logic for closing channels #1015

Merged
merged 3 commits into from
Jun 12, 2019
Merged

Smarter restore logic for closing channels #1015

merged 3 commits into from
Jun 12, 2019

Conversation

pm47
Copy link
Member

@pm47 pm47 commented May 24, 2019

If the closing type is known:

  • there is no need to watch the funding tx because it has already
    been spent and the spending tx has already reached min_depth
  • there is no need to attempt to publish transactions for other
    type of closes.

If the closing type is known:
 - there is no need to watch the funding tx because it has already
 been spent and the spending tx has already reached min_depth
 - there is no need to attempt to publish transactions for other
 type of closes.
@pm47 pm47 requested a review from sstone May 24, 2019 15:21
We can still match on the trait `RemoteClose` if we don't need that
level of precision.
@codecov-io
Copy link

codecov-io commented May 24, 2019

Codecov Report

Merging #1015 into master will increase coverage by 0.34%.
The diff coverage is 44.82%.

@@            Coverage Diff            @@
##           master   #1015      +/-   ##
=========================================
+ Coverage   80.15%   80.5%   +0.34%     
=========================================
  Files          98      98              
  Lines        7554    7647      +93     
  Branches      296     301       +5     
=========================================
+ Hits         6055    6156     +101     
+ Misses       1499    1491       -8
Impacted Files Coverage Δ
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 83.47% <0%> (+0.46%) ⬆️
...c/main/scala/fr/acinq/eclair/payment/Auditor.scala 88.37% <100%> (ø) ⬆️
...c/main/scala/fr/acinq/eclair/channel/Helpers.scala 94.48% <92.3%> (+0.92%) ⬆️
...scala/fr/acinq/eclair/payment/PaymentRequest.scala 90.45% <0%> (-1.61%) ⬇️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 75.25% <0%> (+0.33%) ⬆️
...src/main/scala/fr/acinq/eclair/router/Router.scala 86.72% <0%> (+0.94%) ⬆️
...ir-core/src/main/scala/fr/acinq/eclair/Setup.scala 66.21% <0%> (+2.08%) ⬆️
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala 97.05% <0%> (+3.92%) ⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala 78.49% <0%> (+4.3%) ⬆️
... and 2 more

@pm47 pm47 merged commit 849b6bd into master Jun 12, 2019
@pm47 pm47 deleted the smarter-restore branch June 12, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants