Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output txid and serialized tx in transaction json serializer #1033

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

araspitzu
Copy link
Contributor

For ease of use this PR improves the transaction serializer to output the transaction id along with the serialized transaction, previously we outputted only the serialized transaction.

@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #1033 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
- Coverage   80.58%   80.51%   -0.07%     
==========================================
  Files          98       98              
  Lines        7618     7618              
  Branches      299      299              
==========================================
- Hits         6139     6134       -5     
- Misses       1479     1484       +5
Impacted Files Coverage Δ
...in/scala/fr/acinq/eclair/api/JsonSerializers.scala 96.96% <ø> (ø) ⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala 75.26% <0%> (-7.53%) ⬇️
...cinq/eclair/blockchain/bitcoind/zmq/ZMQActor.scala 89.74% <0%> (-5.13%) ⬇️
.../acinq/eclair/blockchain/electrum/Blockchain.scala 39.68% <0%> (-1.59%) ⬇️
...nq/eclair/blockchain/electrum/ElectrumClient.scala 71.92% <0%> (ø) ⬆️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 83.55% <0%> (+0.19%) ⬆️
...src/main/scala/fr/acinq/eclair/router/Router.scala 86.76% <0%> (+0.94%) ⬆️

Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this hasn't broken any existing API test.

@pm47 pm47 merged commit 199d604 into master Jun 13, 2019
@pm47 pm47 deleted the transaction_serializer_txit branch June 13, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants