Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more memory for scoverage #1050

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Added more memory for scoverage #1050

merged 2 commits into from
Jul 2, 2019

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Jun 26, 2019

This fixes stack overflow error at compile time.

@t-bast
Copy link
Member

t-bast commented Jun 26, 2019

This fixes stack overflow error at compile time.

The fact that one of your builds failed with a Stackoverflow kinda says the opposite :D
Scalac is trolling you

@pm47
Copy link
Member Author

pm47 commented Jun 26, 2019

@t-bast embarrassing...

@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #1050 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1050      +/-   ##
==========================================
+ Coverage   81.92%   82.05%   +0.13%     
==========================================
  Files          97       97              
  Lines        7489     7489              
  Branches      299      299              
==========================================
+ Hits         6135     6145      +10     
+ Misses       1354     1344      -10
Impacted Files Coverage Δ
...nq/eclair/blockchain/electrum/ElectrumClient.scala 73.03% <0%> (+0.74%) ⬆️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 83.57% <0%> (+0.76%) ⬆️

@pm47 pm47 merged commit 48cb864 into master Jul 2, 2019
@pm47 pm47 deleted the fix-scoverage-stack-overflow branch July 2, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants