Electrum improvements #1164
Merged
Electrum improvements #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sstone
commented
Oct 4, 2019
sstone
commented
- electrum client: downgrade log level for some connection events from INFO to DEBUG
- electrum watcher: don't ask for Merkle Proofs for unconfirmed txs (which by definition cannot exist)
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
==========================================
+ Coverage 77.12% 77.15% +0.02%
==========================================
Files 142 142
Lines 9929 9930 +1
Branches 403 403
==========================================
+ Hits 7658 7661 +3
+ Misses 2271 2269 -2
|
pm47
reviewed
Oct 7, 2019
| @@ -92,7 +92,7 @@ class ElectrumClient(serverAddress: InetSocketAddress, ssl: SSL)(implicit val ec | |||
| }) | |||
|
|
|||
| // Start the client. | |||
| log.info("connecting to server={}", serverAddress) | |||
| log.debug("connecting to server={}", serverAddress) | |||
There was a problem hiding this comment.
Not convinced that hiding connection issues is the right thing to do.
| @@ -867,7 +867,7 @@ object ElectrumWallet { | |||
| val confirmedBalance = confirmedReceived.map(_.amount).sum - confirmedSpents.map(_.amount).sum | |||
| val unconfirmedBalance = unconfirmedReceived.map(_.amount).sum - unconfirmedSpents.map(_.amount).sum | |||
|
|
|||
| logger.debug(s"scriptHash=$scriptHash confirmedBalance=$confirmedBalance unconfirmedBalance=$unconfirmedBalance)") | |||
| logger.trace(s"scriptHash=$scriptHash confirmedBalance=$confirmedBalance unconfirmedBalance=$unconfirmedBalance)") | |||
There was a problem hiding this comment.
This is the only trace in the entire code base. Is it really such a special case that we need it here and not anywhere else?
Our info logs were too spammy.
This reverts commit 9d5d5b7.
sstone
force-pushed
the
electrum-improvements
branch
from
15f76e0 to
5db67b4
Compare
t-bast
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.