Payment Request: speed up node id computation #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use native secp256k1 pubkey recovery for faster node id computation
Codecov Report
@@ Coverage Diff @@
## master #1203 +/- ##
=========================================
Coverage ? 76.22%
=========================================
Files ? 138
Lines ? 9382
Branches ? 366
=========================================
Hits ? 7151
Misses ? 2231
Partials ? 0
|
t-bast
reviewed
Nov 13, 2019
eclair-core/src/test/scala/fr/acinq/eclair/payment/PaymentRequestSpec.scala
Outdated
Show resolved
Hide resolved
sstone
force-pushed
the
payment_request_read_faster
branch
from
323fd2a to
df7d8aa
Compare
t-bast
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LN payment requests almost never explicitly include a node id, instead it is recomputed using key recovery. This PR calls native secp256k1 pubkey recovery which is much faster than using Bouncy Castle (it makes a difference for mobile users), and removes the signature check that is useless when pubkey was recovered.
Even though no one AFAICT actually includes the node id field in their PR it is still something that we should implement (in another PR)