Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed race condition in payment handler init #1208

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Nov 13, 2019

When an actor sends a message to itself as part of its class definition,
there is no guarantee that this message will be processed first. Relying
on that to set the default payment handler is problematic and causes
race conditions in tests.

When an actor sends a message to itself as part of its class definition,
there is no guarantee that this message will be processed first. Relying
on that to set the default payment handler is problematic and causes
race conditions in tests.
@pm47 pm47 requested a review from sstone November 13, 2019 09:45
@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #1208 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
+ Coverage   76.17%   76.19%   +0.02%     
==========================================
  Files         138      138              
  Lines        9385     9385              
  Branches      372      367       -5     
==========================================
+ Hits         7149     7151       +2     
+ Misses       2236     2234       -2
Impacted Files Coverage Δ
.../acinq/eclair/payment/receive/PaymentHandler.scala 100% <100%> (ø) ⬆️
...nq/eclair/blockchain/electrum/ElectrumWallet.scala 81.25% <0%> (+0.25%) ⬆️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 75.44% <0%> (+0.29%) ⬆️

@pm47 pm47 merged commit e5060d9 into master Nov 13, 2019
@pm47 pm47 deleted the fix-payment-handler-race branch November 13, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants