High level payments overview method #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
reviewed
Nov 29, 2019
eclair-core/src/main/scala/fr/acinq/eclair/db/sqlite/SqlitePaymentsDb.scala
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/db/sqlite/SqlitePaymentsDb.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1225 +/- ##
==========================================
+ Coverage 76.39% 76.95% +0.56%
==========================================
Files 140 140
Lines 9550 9887 +337
Branches 390 389 -1
==========================================
+ Hits 7296 7609 +313
- Misses 2254 2278 +24
|
pm47
approved these changes
Dec 2, 2019
t-bast
added a commit
that referenced
this pull request
Jul 26, 2022
We introduced a way to get a "light" payments view in #1225. This was a performance improvement for mobile wallets embedding eclair. Mobile wallets should now use lightning-kmp instead of eclair, so we can get rid of that unused code.
t-bast
added a commit
that referenced
this pull request
Jul 26, 2022
We introduced a way to get a "light" payments view in #1225. This was a performance improvement for mobile wallets embedding eclair. Mobile wallets should now use lightning-kmp instead of eclair, so we can get rid of that unused code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a method to get a high level/high performance overview of the payments from the payment database.
The
PaymentDbinterface is impacted to add two objects:PlainIncomingPaymentandPlainOutgoingPayment. These objects only contains the most basic data about the payments.Notably, the payment request attribute in these object is the raw serialized value stored in the DB which helps with performances on Android. Two methods have been added to the
PaymentRequestobject to allow for the fast reading of a serialized payment request's description and expiry.This PR supercedes #1169