Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended doHandle to other messages in MultiPartHandler #1226

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Nov 29, 2019

No description provided.

@pm47 pm47 requested a review from t-bast November 29, 2019 15:38
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1226 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1226      +/-   ##
==========================================
+ Coverage   76.28%   76.42%   +0.13%     
==========================================
  Files         140      140              
  Lines        9565     9568       +3     
  Branches      389      398       +9     
==========================================
+ Hits         7297     7312      +15     
+ Misses       2268     2256      -12
Impacted Files Coverage Δ
...cinq/eclair/payment/receive/MultiPartHandler.scala 94.18% <100%> (+0.21%) ⬆️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 75.44% <0%> (+0.29%) ⬆️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 83.74% <0%> (+0.46%) ⬆️
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 51.72% <0%> (+1.72%) ⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala 78.49% <0%> (+4.3%) ⬆️

@pm47 pm47 merged commit b5f993c into master Nov 29, 2019
@pm47 pm47 deleted the mpp-dohandle branch November 29, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants