Fix outgoing payments order in payments overview #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1232 +/- ##
==========================================
+ Coverage 76.55% 76.68% +0.12%
==========================================
Files 140 140
Lines 9700 9700
Branches 397 397
==========================================
+ Hits 7426 7438 +12
+ Misses 2274 2262 -12
|
t-bast
previously approved these changes
Dec 4, 2019
t-bast
approved these changes
Dec 4, 2019
pm47
pushed a commit
that referenced
this pull request
Dec 12, 2019
Using the `max()` aggregating function on outgoing payments' timestamps, we can ensure that the non-aggregated columns for the outgoing payments contain the most recent/pertinent data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payments overview aggregates outgoing payments by
parent_idusing agroup by. If there are several attempts, there is no guarantee that the output aggregated payment will hold the most recent/pertinent status.See SQLite doc on bare columns in aggregate queries: https://www.sqlite.org/lang_select.html#bareagg
By using the
maxfunction we can force the aggregate output to be the most recent attempt.