Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MPP flaky test #1243

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Fix MPP flaky test #1243

merged 1 commit into from
Dec 9, 2019

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Dec 9, 2019

We can't guarantee with the current algorithm that the last HTLC won't be
a small one (the leftovers).
If we see that happen in real scenario, we'll need to add heuristics to avoid it.

@t-bast
Fix MPP flaky test
69f2523 
We can't guarantee with the current algorithm that the last HTLC won't be
a small one (the leftovers).
If we see that happen in real scenario, we'll need to add heuristics to avoid it.
@t-bast t-bast requested a review from araspitzu December 9, 2019 13:00
araspitzu
araspitzu approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@araspitzu araspitzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the flaky test and acknowledges the current MPP split algorithm might generate small leftover HTLC, ACK!

@t-bast t-bast merged commit b6511ad into master Dec 9, 2019
@t-bast t-bast deleted the mpp-test-fix branch December 9, 2019 13:12
@araspitzu araspitzu mentioned this pull request Dec 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@araspitzu araspitzu araspitzu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-bast @araspitzu