Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CommandSend type #1260

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Improve CommandSend type #1260

merged 1 commit into from
Dec 18, 2019

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Dec 18, 2019

Add type with upper bound to make asInstanceOf unnecessary.
Split HasHtlcId from Command: they are orthogonal traits.

Add type with upper bound to make `asInstanceOf` unnecessary.
Split `HasHtlcId` from `Command`: they are orthogonal traits.
@t-bast t-bast requested a review from pm47 December 18, 2019 14:53
@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #1260 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
+ Coverage   77.03%   77.15%   +0.12%     
==========================================
  Files         142      142              
  Lines        9880     9880              
  Branches      402      402              
==========================================
+ Hits         7611     7623      +12     
+ Misses       2269     2257      -12
Impacted Files Coverage Δ
.../fr/acinq/eclair/payment/relay/CommandBuffer.scala 100% <ø> (ø) ⬆️
.../acinq/eclair/db/sqlite/SqlitePendingRelayDb.scala 100% <ø> (ø) ⬆️
...n/scala/fr/acinq/eclair/channel/ChannelTypes.scala 90% <ø> (ø) ⬆️
...ain/scala/fr/acinq/eclair/wire/CommandCodecs.scala 100% <100%> (ø) ⬆️
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 51.72% <0%> (-0.87%) ⬇️
...nq/eclair/blockchain/electrum/ElectrumClient.scala 73.28% <0%> (-0.37%) ⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 83.8% <0%> (+0.09%) ⬆️
...nq/eclair/blockchain/electrum/ElectrumWallet.scala 81% <0%> (+0.25%) ⬆️
...src/main/scala/fr/acinq/eclair/router/Router.scala 92.71% <0%> (+0.71%) ⬆️
...cala/fr/acinq/eclair/crypto/TransportHandler.scala 92.3% <0%> (+1.18%) ⬆️
... and 2 more

Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much better.

@t-bast t-bast merged commit 80b6420 into master Dec 18, 2019
@t-bast t-bast deleted the typed-command-send branch December 18, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants