Do not include optional timestamp/checksum TLV if they are empty #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll make it ready for review as soon as I've added proper tests |
Codecov Report
@@ Coverage Diff @@
## master #1280 +/- ##
==========================================
+ Coverage 77.11% 77.17% +0.06%
==========================================
Files 142 142
Lines 9934 9934
Branches 417 417
==========================================
+ Hits 7661 7667 +6
+ Misses 2273 2267 -6
|
t-bast
reviewed
Jan 16, 2020
eclair-core/src/test/scala/fr/acinq/eclair/router/ChannelRangeQueriesSpec.scala
Outdated
Show resolved
Hide resolved
|
Test against c-lighting (at ElementsProject/lightning@4be1868) and lnd (https://github.com/lightningnetwork/lnd/releases/tag/v0.9.0-beta-rc2) |
sstone
changed the title
Don't include optional timestmap or checksum TLVs if they are empty (i.e. there are no scids in the current block range)
t-bast
approved these changes
Jan 20, 2020
|
I think previous implementation made more sense. How can I tell now that my peer understood that I requested additional data, but just doesn't have any? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an interop issue with c-lighting, which does not handle
reply_channel_rangemessages that include an optiontimestampsTLV that contains an empty array of timestamps with aZLIBencodingand fails with aconnection-level error, failing all channels! reason=reply_channel_range 0 timestamps when 0 scids?` errorIt is related to lightning/bolts#729