Allow deactivating MPP #1289
Merged
Allow deactivating MPP #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When paying an invoice, we weren't properly checking our own features. If the invoice supported MPP, we would use it all the time. If MPP isn't enabled in our features, we now default to a legacy payment.
Codecov Report
@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
+ Coverage 77.19% 77.22% +0.03%
==========================================
Files 143 143
Lines 9975 9976 +1
Branches 423 408 -15
==========================================
+ Hits 7700 7704 +4
+ Misses 2275 2272 -3
|
dpad85
pushed a commit
that referenced
this pull request
Jan 24, 2020
When paying an invoice, we weren't properly checking our own features. If the invoice supported MPP, we would use it all the time. If MPP isn't enabled in our features, we now default to a legacy payment. (cherry picked from commit 60359c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When paying an invoice, we weren't properly checking our own features.
If the invoice supported MPP, we would use it all the time.
If MPP isn't enabled in our features, we now default to a legacy payment.