Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify ChannelsDb htlc info method #1291

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Clarify ChannelsDb htlc info method #1291

merged 1 commit into from
Jan 29, 2020

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Jan 24, 2020

The old name (addOrUpdateHtlcInfo) was misleading.
This method only adds, and can even handle adding duplicate lines.

Closes #1233

The old name (addOrUpdateHtlcInfo) was misleading.
This method only adds, and can even handle adding duplicate lines.

Closes #1233
@t-bast t-bast requested a review from pm47 January 24, 2020 14:32
@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #1291 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #1291     +/-   ##
=========================================
+ Coverage   77.18%   77.28%   +0.1%     
=========================================
  Files         143      143             
  Lines        9976     9976             
  Branches      408      408             
=========================================
+ Hits         7700     7710     +10     
+ Misses       2276     2266     -10
Impacted Files Coverage Δ
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 83.56% <100%> (ø) ⬆️
...a/fr/acinq/eclair/db/sqlite/SqliteChannelsDb.scala 95.91% <100%> (ø) ⬆️
...nq/eclair/blockchain/electrum/ElectrumWallet.scala 81% <0%> (+0.25%) ⬆️
...src/main/scala/fr/acinq/eclair/router/Router.scala 92.97% <0%> (+0.68%) ⬆️
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 52.13% <0%> (+0.85%) ⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala 78.49% <0%> (+4.3%) ⬆️

Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @btcontract

@t-bast t-bast merged commit 8d80d13 into master Jan 29, 2020
@t-bast t-bast deleted the db-htlc-info-clarify branch January 29, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange name and logic for ChannelsDb.addOrUpdateHtlcInfo
3 participants