Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electrum: add support for socks5 proxies #1315

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Conversation

sstone
Copy link
Member

@sstone sstone commented Feb 11, 2020

We use the same socks5 proxy that is optionally enabled in the configuration and is typically used to connect to LN nodes running as TOR hidden services.

This will allow eclair:

  • to connect to .onion Electrum servers running behind TOR
  • to connect to regular Electrum servers through TOR

@codecov-io
Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #1315 into master will increase coverage by 0.15%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master   #1315      +/-   ##
=========================================
+ Coverage   77.45%   77.6%   +0.15%     
=========================================
  Files         144     144              
  Lines       10130   10132       +2     
  Branches      414     392      -22     
=========================================
+ Hits         7846    7863      +17     
+ Misses       2284    2269      -15
Impacted Files Coverage Δ
...ir-core/src/main/scala/fr/acinq/eclair/Setup.scala 73.29% <0%> (ø) ⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala 82.79% <100%> (+4.3%) ⬆️
...nq/eclair/blockchain/electrum/ElectrumClient.scala 73.83% <100%> (+0.18%) ⬆️
...in/scala/fr/acinq/eclair/channel/Commitments.scala 90.68% <0%> (+0.35%) ⬆️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 83.68% <0%> (+0.45%) ⬆️
...src/main/scala/fr/acinq/eclair/router/Router.scala 92.56% <0%> (+0.67%) ⬆️
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 55.2% <0%> (+0.8%) ⬆️

We use the socks5 proxy that is defined in the configuration and is typically used to connect to LN nodes running as TOR hidden services.
This should allow users to connect to Electrum servers that are running behind TOR.
@sstone sstone force-pushed the electrum-use-socks5-proxy branch from 141bc91 to 022a48d Compare February 11, 2020 13:25
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, how can we test that? With a manual test on a machine with Tor?

@sstone
Copy link
Member Author

sstone commented Feb 11, 2020

Yes, with a manual test using Tor's default proxy (just setting eclair.socks5.enabled to true should be enough)

@sstone sstone merged commit b730300 into master Feb 11, 2020
@sstone sstone deleted the electrum-use-socks5-proxy branch February 11, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants