Re-send ChannelUpdate on reconnection (vol 2) #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation in #1317 wasn't working because in a bug in the transition. Added a test and fixed it.
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
==========================================
+ Coverage 78.14% 78.23% +0.09%
==========================================
Files 146 146
Lines 10270 10270
Branches 396 396
==========================================
+ Hits 8025 8035 +10
+ Misses 2245 2235 -10
|
t-bast
reviewed
Mar 10, 2020
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/OfflineStateSpec.scala
Outdated
Show resolved
Hide resolved
| alice2bob.expectNoMsg() | ||
| bob2alice.expectNoMsg() | ||
|
|
||
| // funding tx gets 6 confirmations, channel is private so there is no announcement sigs |
There was a problem hiding this comment.
You should have an alice2bob.expectNoMsg() to verify that no announcement sig is sent, don't you?
There was a problem hiding this comment.
We receive ChannelUpdates instead.
There was a problem hiding this comment.
Isn't there a way to expect no message of type X?
Co-Authored-By: Bastien Teinturier <31281497+t-bast@users.noreply.github.com>
t-bast
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation in #1317 wasn't working because of a bug in the
transition. Added a test and fixed it.
cc @t-bast @btcontract