Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information to GetInfoResponse #1344

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Add more information to GetInfoResponse #1344

merged 1 commit into from
Mar 10, 2020

Conversation

araspitzu
Copy link
Contributor

@araspitzu araspitzu commented Mar 10, 2020

This PR adds some extra information in the /getinfo API response such as version, color and features, the version string uses a truncated commit and is also used to log the version during boot.

  • update documentation

@araspitzu araspitzu marked this pull request as ready for review March 10, 2020 11:22
@codecov-io
Copy link

codecov-io commented Mar 10, 2020

Codecov Report

Merging #1344 into master will increase coverage by 0.07%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
+ Coverage   78.05%   78.12%   +0.07%     
==========================================
  Files         146      146              
  Lines       10270    10277       +7     
  Branches      396      412      +16     
==========================================
+ Hits         8016     8029      +13     
+ Misses       2254     2248       -6
Impacted Files Coverage Δ
...r-core/src/main/scala/fr/acinq/eclair/Eclair.scala 53.53% <0%> (-2.26%) ⬇️
...ir-core/src/main/scala/fr/acinq/eclair/Setup.scala 73.18% <75%> (-0.12%) ⬇️
...in/scala/fr/acinq/eclair/channel/Commitments.scala 90.94% <0%> (+0.34%) ⬆️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 85.03% <0%> (+0.54%) ⬆️
...src/main/scala/fr/acinq/eclair/router/Router.scala 92.65% <0%> (+0.66%) ⬆️

Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@araspitzu araspitzu merged commit 65371cd into master Mar 10, 2020
@araspitzu araspitzu deleted the enrich_getinfo branch March 10, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants